fix(codex): render plans in approval UI#3524
Conversation
Generated-By: PostHog Code Task-Id: 2cd7c8b3-ddf5-4e4c-994d-1f5bbafabff0
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "fix(codex): render plans in approval UI" | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: 2cd7c8b3-ddf5-4e4c-994d-1f5bbafabff0
|
Reviews (2): Last reviewed commit: "fix(codex): harden plan approval lifecyc..." | Re-trigger Greptile |
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
Generated-By: PostHog Code Task-Id: 7305b2f0-aa76-413e-b0ea-a2078250be66
There was a problem hiding this comment.
All bot-raised concerns (cancellation timing, stuck terminal status, misleading rejection copy, unbounded plan snapshots) are demonstrably addressed in the current diff with targeted fixes and matching tests. No unresolved review comments, no security or data-model concerns.
Problem
Codex plan output renders as regular chat markdown instead of the dedicated plan approval UI used by Claude.
BEfore:

After:

Changes
How did you test this?
pnpm --filter @posthog/agent exec vitest run src/adapters/codex-app-server/mapping.test.ts src/adapters/codex-app-server/codex-app-server-agent.test.tspnpm --filter @posthog/ui exec vitest run src/features/sessions/components/session-update/PlanApprovalView.test.tsxpnpm --filter @posthog/agent typecheckpnpm --filter @posthog/ui typecheckpnpm typecheckAutomatic notifications
Created with PostHog Code