fix(sessions): dedupe cloud completion notifications#3572
Merged
richardsolomou merged 4 commits intoJul 20, 2026
Conversation
Generated-By: PostHog Code Task-Id: 456e7b37-67a4-4163-a9c9-749c5ff36cbe
|
😎 Merged manually by @richardsolomou - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
richardsolomou
marked this pull request as ready for review
July 20, 2026 06:18
Contributor
|
Reviews (1): Last reviewed commit: "fix(sessions): dedupe cloud completion n..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
✅ Visual changes approved by @richardsolomou — baseline updated in 1 changed. |
Generated-By: PostHog Code Task-Id: 456e7b37-67a4-4163-a9c9-749c5ff36cbe
adamleithp
approved these changes
Jul 20, 2026
1 updated Run: ad8db4b1-d88d-42ea-a362-ce200a22839c Co-authored-by: richardsolomou <2622273+richardsolomou@users.noreply.github.com>
richardsolomou
deleted the
posthog-code/fix-cloud-completion-notifications
branch
July 20, 2026 12:25
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cloud runs can write duplicate
turn_completeentries for the same prompt.SessionServicetreated every live entry as a new completion, so one task could trigger two toasts and two sounds. Completion notifications should follow the prompt lifecycle, not the raw event count.Changes
I only send the completion notification while the cloud turn is still active. Duplicate and unarmed completion entries can still update idle state without notifying, with regression cases covering both sequences.
How did you test this?
pnpm --dir packages/core exec vitest run src/sessions/cloudTaskUpdateNotifications.test.tspnpm exec biome lint packages/corepnpm --filter @posthog/core typecheckAutomatic notifications
Created with PostHog Code