Skip to content

feat(notifications): add MSN Messenger completion sound#3605

Merged
trunk-io[bot] merged 1 commit into
mainfrom
add-msn-messenger-sound
Jul 21, 2026
Merged

feat(notifications): add MSN Messenger completion sound#3605
trunk-io[bot] merged 1 commit into
mainfrom
add-msn-messenger-sound

Conversation

@patricio-posthog

Copy link
Copy Markdown
Contributor

Summary

Adds the MSN Messenger sound as a new built-in completion sound option. Users can select it under Settings → Notifications → Sound effect, and it plays when an agent finishes a task or needs input (like the other built-in sounds).

Changes

  • Add msn.mp3 asset to packages/ui/src/assets/sounds/
  • Register "msn" in the BuiltInCompletionSound union (settingsStore.ts)
  • Wire the import + SOUND_URLS entry (sounds.ts)
  • Add the MSN Messenger option to the sound dropdown (NotificationsSettings.tsx)

Testing

Ran the app locally and confirmed the sound plays via the ▶ Test sound button in Settings → Notifications, and at the selected volume.

Add the MSN Messenger notification sound as a built-in completion sound
option, selectable from Settings > Notifications > Sound effect.
@trunk-io

trunk-io Bot commented Jul 20, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 2f4cf25.

@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "feat(notifications): add MSN Messenger c..." | Re-trigger Greptile

@charlesvien charlesvien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOL

@trunk-io
trunk-io Bot merged commit d9f9204 into main Jul 21, 2026
28 checks passed
@trunk-io
trunk-io Bot deleted the add-msn-messenger-sound branch July 21, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants