Skip to content

fix(settings): Show available update in Updates panel#3678

Merged
charlesvien merged 1 commit into
mainfrom
fix/updates-settings-available-status
Jul 22, 2026
Merged

fix(settings): Show available update in Updates panel#3678
charlesvien merged 1 commit into
mainfrom
fix/updates-settings-available-status

Conversation

@charlesvien

Copy link
Copy Markdown
Member

Problem

Clicking "Check now" in Settings > Updates while an update is available leaves the row stuck on "Checking for updates...", even though the rest of the app shows the update banner.

Changes

When a check finds an update, the updates service emits a status with checking: false, available: true, but deriveUpdateStatus had no case for it, so the stale checking message was never replaced. Added an available case ("Update x.y.z available") and an error case so async check failures (e.g. timeouts) no longer leave the row stuck either.

How did you test this?

Unit tests for the new cases (vitest run src/settings/updateStatus.test.ts, 14 passed), plus full pnpm typecheck and Biome lint.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@trunk-io

trunk-io Bot commented Jul 22, 2026

Copy link
Copy Markdown

😎 This pull request was merged.

@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 233f3bc.

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "show available update status in settings..." | Re-trigger Greptile

@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jul 22, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, contained fix adding two missing status cases (available/error) to a pure derive function, with matching unit tests; no risky territory touched and no unresolved concerns.

  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 15L, 1F substantive, 50L/2F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1b-small (50L, 2F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ ed26e21 · reviewed head 233f3bc

@charlesvien charlesvien added the Create Release This will trigger a new release label Jul 22, 2026
@charlesvien
charlesvien merged commit f1563f9 into main Jul 22, 2026
39 checks passed
@charlesvien
charlesvien deleted the fix/updates-settings-available-status branch July 22, 2026 07:49
@github-actions

Copy link
Copy Markdown

Could not verify team-posthog-code membership (GitHub API error). Auto-release is limited to members of the team-posthog-code GitHub team, so this will ship with the next scheduled release instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Create Release This will trigger a new release Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant