fix(settings): Show available update in Updates panel#3678
Merged
Conversation
|
😎 This pull request was merged. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "show available update status in settings..." | Re-trigger Greptile |
There was a problem hiding this comment.
Small, contained fix adding two missing status cases (available/error) to a pure derive function, with matching unit tests; no risky territory touched and no unresolved concerns.
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 15L, 1F substantive, 50L/2F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (50L, 2F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ ed26e21 · reviewed head 233f3bc |
|
Could not verify team-posthog-code membership (GitHub API error). Auto-release is limited to members of the team-posthog-code GitHub team, so this will ship with the next scheduled release instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking "Check now" in Settings > Updates while an update is available leaves the row stuck on "Checking for updates...", even though the rest of the app shows the update banner.
Changes
When a check finds an update, the updates service emits a status with
checking: false, available: true, butderiveUpdateStatushad no case for it, so the stale checking message was never replaced. Added anavailablecase ("Update x.y.z available") and anerrorcase so async check failures (e.g. timeouts) no longer leave the row stuck either.How did you test this?
Unit tests for the new cases (
vitest run src/settings/updateStatus.test.ts, 14 passed), plus fullpnpm typecheckand Biome lint.Automatic notifications