Expand truncated prompts in channel feeds#3698
Merged
Merged
Conversation
Generated-By: PostHog Code Task-Id: c77b603d-2995-4295-b17b-4e3043ed37a2
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
✅ Visual changes approved by @k11kirky — baseline updated in 2 changed. |
k11kirky
marked this pull request as ready for review
July 22, 2026 13:03
2 updated Run: 97a9a415-0f01-4f2d-a295-870be136abeb Co-authored-by: k11kirky <4571455+k11kirky@users.noreply.github.com>
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/canvas/components/ChannelFeedView.tsx:451-455
**Expansion State Is Not Announced**
The new control changes whether the prompt is collapsed, but it does not expose that state to assistive technology. Screen-reader users hear “more” or “less” without the button’s expanded state, so the new interaction does not communicate whether the full prompt is currently visible.
```suggestion
<button
type="button"
aria-expanded={expanded}
className="text-muted-foreground text-xs underline underline-offset-2 hover:text-foreground"
onClick={() => setExpanded((value) => !value)}
>
```
Reviews (1): Last reviewed commit: "chore(visual): update storybook baseline..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Contained UI-only feature (expand/collapse for truncated feed prompts) with new tests; the sole reviewer concern (missing aria-expanded) is already implemented in the diff, and no risky territory (auth, data, API, CI, deps) is touched.
- Author wrote 0% of the modified lines and has 68 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 64L, 2F substantive, 109L/3F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (109L, 3F, two-areas, unknown) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 7b426cd · reviewed head cea3fce |
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long task prompts in channel feeds are truncated with no way to read the full message.
Changes
Why: Users need to read the complete prompt without leaving the channel context.
How did you test this?
pnpm --filter @posthog/ui exec vitest run src/features/canvas/components/ChannelFeedView.test.tsxpnpm --filter @posthog/ui typecheckpnpm exec biome check packages/ui/src/features/canvas/components/ChannelFeedView.tsx packages/ui/src/features/canvas/components/ChannelFeedView.test.tsxAutomatic notifications
Created with PostHog Code