fix(shortcuts): bind Steer/Queue toggle to Ctrl+S instead of Cmd+S#3709
Merged
Conversation
SWITCH_MESSAGING_MODE used "mod+s", which maps to Cmd on macOS. Bind it to the literal Ctrl key so the toggle is consistent across platforms (and not Cmd-dependent on Mac). Generated-By: PostHog Code Task-Id: d892bbfc-d26c-4b72-ac04-fbe4c6e52a93
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
added
the
Stamphog
tatoalo
marked this pull request as ready for review
July 22, 2026 14:09
Contributor
|
Reviews (1): Last reviewed commit: "fix(shortcuts): bind Steer/Queue toggle ..." | Re-trigger Greptile |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Trivial one-line keybinding constant change matching the PR description exactly, no risky territory involved.
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 2L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (2L, 1F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 79e156c · reviewed head 4d71687 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Steer/Queue messaging-mode toggle was bound to
Cmd+Son macOS (via"mod+s"), which conflicts with the platform's save convention and is inconsistent across platforms. The toggle should use the literal Control key on all platforms.Changes
SWITCH_MESSAGING_MODEtoctrl+sinstead ofmod+sinpackages/ui/src/features/command/keyboard-shortcuts.ts, so the toggle listens for Control/Ctrl+S everywhere instead of Cmd+S on macOS. The hotkey hint in the Steer/Queue tooltip updates automatically viaformatHotkey.