Skip to content

fix: support Slack workspaces in loop notifications#3721

Merged
trunk-io[bot] merged 4 commits into
mainfrom
posthog-code/fix-loop-slack-channel-picker
Jul 22, 2026
Merged

fix: support Slack workspaces in loop notifications#3721
trunk-io[bot] merged 4 commits into
mainfrom
posthog-code/fix-loop-slack-channel-picker

Conversation

@MattPua

@MattPua MattPua commented Jul 22, 2026

Copy link
Copy Markdown
Member

Problem

Loop Slack destinations searched only the first connected workspace, making channels in other connected workspaces unavailable.

Changes

Before:
CleanShot 2026-07-22 at 12 37 41@2x

After

CleanShot.2026-07-22.at.12.37.08.mp4
  • add a shared Slack workspace selector
  • select a workspace before choosing a Loop notification channel
  • preload the first channel page and keep search server-side
  • preserve accessible loading and clearing behavior

How did you test this?

  • pnpm --filter @posthog/ui typecheck
  • pnpm exec vitest run src/features/settings/components/SlackChannelCombobox.test.tsx
  • Biome check on changed files
  • fresh QA reviewer pass

Root pnpm typecheck remains blocked by unrelated existing @posthog/web module-resolution errors for @posthog/agent and @posthog/host-trpc.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: e2b452a2-5abd-4732-82bd-2e380f30a465
@trunk-io

trunk-io Bot commented Jul 22, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 84328e8.

Generated-By: PostHog Code
Task-Id: e2b452a2-5abd-4732-82bd-2e380f30a465
@MattPua
MattPua marked this pull request as ready for review July 22, 2026 16:44
Generated-By: PostHog Code
Task-Id: e2b452a2-5abd-4732-82bd-2e380f30a465
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/ui/src/features/settings/sections/SlackInboxNotificationsSettings.tsx:68
**Team Default Uses First Workspace**

With multiple Slack integrations, this always loads the team default channel from `slackIntegrations[0]`. If the saved default belongs to another workspace, the picker queries the wrong channel list and offers no way to select the correct workspace, so the displayed workspace and persisted channel can disagree.

Reviews (1): Last reviewed commit: "refactor: extract Slack workspace channe..." | Re-trigger Greptile

Comment thread packages/ui/src/features/settings/sections/SlackInboxNotificationsSettings.tsx Outdated
Generated-By: PostHog Code
Task-Id: e2b452a2-5abd-4732-82bd-2e380f30a465
@trunk-io
trunk-io Bot merged commit 9a06399 into main Jul 22, 2026
33 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/fix-loop-slack-channel-picker branch July 22, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants