feat(loops): surface loop ownership and notifications#3723
Merged
Conversation
|
😎 This pull request was merged. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
✅ Visual changes approved by @MattPua — baseline updated in 4 new. |
MattPua
marked this pull request as ready for review
July 22, 2026 18:20
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
packages/ui/src/features/loops/components/LoopsListView.tsx:67
**Members Cache Crosses Organizations**
`useOrgMembers` uses the shared `['org-members']` cache key, so switching organizations can leave this new creator lookup reading the previous organization's members during the stale window. Team loops can then show another user's name when numeric IDs overlap, or incorrectly label a current creator as a former member.
### Issue 2 of 2
packages/ui/src/features/loops/components/LoopDetailView.tsx:264-265
**Partial Results Imply Former Member**
The organization-members request stops after 20 pages and returns the members loaded so far. In an organization with more than 4,000 members, a current creator on a later page is absent from `members`, so this branch incorrectly displays “Former organization member.”
Reviews (1): Last reviewed commit: "chore(visual): update storybook baseline..." | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: 5e66a9a6-6aca-44f1-8f6a-ba8a7c1dbd7b
Generated-By: PostHog Code Task-Id: 5e66a9a6-6aca-44f1-8f6a-ba8a7c1dbd7b
Generated-By: PostHog Code Task-Id: 5e66a9a6-6aca-44f1-8f6a-ba8a7c1dbd7b
Generated-By: PostHog Code Task-Id: 5e66a9a6-6aca-44f1-8f6a-ba8a7c1dbd7b
Generated-By: PostHog Code Task-Id: 5e66a9a6-6aca-44f1-8f6a-ba8a7c1dbd7b
Generated-By: PostHog Code Task-Id: 5e66a9a6-6aca-44f1-8f6a-ba8a7c1dbd7b
Generated-By: PostHog Code Task-Id: 5e66a9a6-6aca-44f1-8f6a-ba8a7c1dbd7b
4 updated Run: 96ef43a9-bfac-48d5-a987-da09c8ad27f1 Co-authored-by: MattPua <3376526+MattPua@users.noreply.github.com>
Generated-By: PostHog Code Task-Id: 9edb68e1-a82b-48f8-9d42-f3c635939c09
charlesvien
force-pushed
the
posthog-code/surface-loop-metadata
branch
from
July 23, 2026 04:25
11346fe to
f1b2b5e
Compare
charlesvien
enabled auto-merge (squash)
July 23, 2026 04:32
charlesvien
approved these changes
Jul 23, 2026
charlesvien
disabled auto-merge
July 23, 2026 04:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Loop lists and details hide notification channels and ownership, and personal and team loops are mixed together.
Changes
Before:


After:

How did you test this?
pnpm --filter @posthog/ui typecheckpnpm --dir packages/ui exec vitest run src/features/loops/loopDisplay.test.ts src/features/canvas/utils/mentionComposer.test.tspnpm exec biome checkon changed filesAutomatic notifications
Created with PostHog Code