Skip to content
This repository was archived by the owner on Nov 4, 2021. It is now read-only.

Slightly change the way changing team_id by plugins is illegal - #396

Merged
Twixes merged 3 commits into
masterfrom
slight-team-id-ensuring-change
May 19, 2021
Merged

Twixes merged 3 commits into
masterfrom
slight-team-id-ensuring-change

Conversation

@Twixes

ghost commented May 19, 2021

Copy link
Copy Markdown
Contributor

Changes

So this PR adds the feature to batch processing like #394, but instead of silently restoring the correct team_id (unlike master which nullifies the event), it restores it AND throws an IllegalOperationError. This way the impact of illegally operating plugins is minimized, but the problem is still communicated as an error. Closes #394.

Checklist

  • Jest tests

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bump patch Bump patch version when this PR gets merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants