Skip to content

shouldSendFeatureFlags can make lose events #29

Closed

Description

@BattleShipPark

In PostHog.java:479

if (shouldSendFeatureFlags) {
  ValueMap flags = featureFlags.getFlagVariants();
  List<String> activeFlags = featureFlags.getFlags();

An exception happens if PostHogFeatureFlags.reloadFeatureFlagsRequest() did not finish when featureFlags.getFlags() was called.
Although this does not make my app crash, it makes lose my very early events before reloadFeatureFlagsRequest() finishes.

Activity

  1. marandaneto commented on Sep 22, 2023

    @marandaneto
    Member

    We're currently reworking the Android SDK and this will be taken care of, will move this to WIP, so stay tuned.

  2. marandaneto commented on Oct 4, 2023

    @marandaneto
    Member

    https://github.com/PostHog/posthog-android/releases/tag/3.0.0-alpha.4 should fix this.
    If the reloadFeatureFlags isn't finished, feature flags will just return null.
    You can choose to listen for a callback once feature flags are fully reloaded.
    Check out https://github.com/PostHog/posthog-android/blob/main/USAGE.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions