Repository navigation
chore: implement setPersonProps method - #369
Conversation
| if (userPropertiesToSet.isNullOrEmpty() && userPropertiesToSetOnce.isNullOrEmpty()) { | ||
| return | ||
| } |
There was a problem hiding this comment.
js does the same, but just curious in general, how do we allow clearing person properties? My understanding is that $set is additive, should we have an unsetPersonProperties() counterpart that sets $unset property?
There was a problem hiding this comment.
There was a problem hiding this comment.
JS SDK does not have $unset but yeah good call, nor resetPersonProperties(), i will keep as is for now like the JS SDK
ioannisj
left a comment
There was a problem hiding this comment.
LG. Sorting is one level though if I'm not mistaken, so nested maps will still be unsorted but I leave that up to you. Should be better that just unsorted already
good point, fixed |
💡 Motivation and Context
Implements #194
💚 How did you test it?
📝 Checklist