Skip to content

chore: implement setPersonProps method - #369

Merged
marandaneto merged 5 commits into
mainfrom
chore/personprops
Jan 16, 2026
Merged

marandaneto merged 5 commits into
mainfrom
chore/personprops

Conversation

@marandaneto

@marandaneto marandaneto commented Jan 15, 2026 •

Copy link
Copy Markdown
Member

💡 Motivation and Context

Implements #194

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.
  • If there are related changes in the core package, I've already released them, or I'll release them before this one.

Comment on lines +735 to +737
if (userPropertiesToSet.isNullOrEmpty() && userPropertiesToSetOnce.isNullOrEmpty()) {
return
}

@ioannisj ioannisj Jan 16, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js does the same, but just curious in general, how do we allow clearing person properties? My understanding is that $set is additive, should we have an unsetPersonProperties() counterpart that sets $unset property?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS SDK does not have $unset but yeah good call, nor resetPersonProperties(), i will keep as is for now like the JS SDK

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marandaneto
marandaneto marked this pull request as ready for review January 16, 2026 12:42
@marandaneto
marandaneto requested a review from a team January 16, 2026 12:42
@marandaneto
marandaneto requested a review from ioannisj January 16, 2026 12:43

@ioannisj ioannisj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Sorting is one level though if I'm not mistaken, so nested maps will still be unsorted but I leave that up to you. Should be better that just unsorted already

@marandaneto

Copy link
Copy Markdown
Member Author

LG. Sorting is one level though if I'm not mistaken, so nested maps will still be unsorted but I leave that up to you. Should be better that just unsorted already

good point, fixed

@marandaneto
marandaneto merged commit ebbde67 into main Jan 16, 2026
13 of 14 checks passed
@marandaneto
marandaneto deleted the chore/personprops branch January 16, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants