fix: Preserve exception stack frame paths#215
Closed
marandaneto wants to merge 2 commits into
Closed
Conversation
posthog-ruby Compliance ReportDate: 2026-07-03 09:39:13 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
|
Reviews (1): Last reviewed commit: "fix: Preserve relative exception filenam..." | Re-trigger Greptile |
Member
Author
|
@PostHog/team-error-tracking not sure if thats what we want, but opened a pr with a possible fix, lemme know |
Contributor
|
Yes, it should be fixed with this PR: #214 |
Member
Author
|
closing in favor of #214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Fixes #212.
Captured exception stack frames currently set
filenametoFile.basename(abs_path), which drops project-relative directories such asapp/services/foo/bar.rb. PostHog Error Tracking rendersfilename, so frames with the same basename become hard to distinguish.This change preserves useful relative paths for stack frame filenames while keeping
abs_pathunchanged. The changeset covers bothposthog-rubyandposthog-railsbecause Rails users are affected by the captured exception payload.💚 How did you test it?
bundle exec rspec spec/posthog/exception_capture_spec.rbbundle exec rspecbundle exec rubocop📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent implemented this change in a dedicated git worktree. The implementation follows the issue recommendation by computing stack frame filenames from known roots: Rails.root or the current working directory for in-app frames, and the longest matching
$LOAD_PATHentry for gem frames. The fallback keeps the original path rather than collapsing to a basename, so directory context is preserved.Follow-up review feedback replaced the trailing slash regex with a linear implementation, evaluated
Rails.rootonly once, and added the Rails changeset entry.