Skip to content

Fix React #418 hydration mismatch in App context - #17642

Closed
posthog[bot] wants to merge 1 commit into
masterfrom
posthog-code/fix-react-418-hydration-mismatch
Closed

posthog[bot] wants to merge 1 commit into
masterfrom
posthog-code/fix-react-418-hydration-mismatch

Conversation

@posthog

@posthog posthog Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Changes

getInitialSiteSettings in src/context/App.tsx read browser-only state (window.__theme, localStorage, window.innerWidth, iframe detection) during the initial render, so the first client render disagreed with the server-rendered markup for every dark-mode, mobile, or iframe-embedded visitor. React detected the divergence and emitted Minified React error #418 (a hydration mismatch) — ~4.7M occurrences across ~282K users in the last 30 days.

This change makes the first client render identical to the server output:

  • Split the old function into a static SERVER_SITE_SETTINGS constant (what the server renders with) and a getClientSiteSettings helper that reads real browser state.
  • siteSettings, isMobile, and compact now initialize from the server-rendered defaults.
  • A post-mount useEffect applies the real browser-derived values after hydration completes, so React only re-renders client-side (no mismatch).

The server already rendered in light/desktop mode for everyone, so affected users already received that markup and re-rendered — this just turns that into a clean setState re-render instead of a hydration-error-triggered one, removing the error-tracking noise without changing the end-state UX. The suppressHydrationWarning band-aid at AppWindow/index.tsx:611 is left in place but is no longer load-bearing.

Why

The #418 hydration mismatch was one of the highest-volume errors on the site (4,710,606 occurrences / 281,983 users in 30 days), flooding error tracking and burning ingestion volume even though React silently recovered. Fixing the SSR/client state divergence at the source eliminates the errors rather than suppressing them per-window.

Checklist

  • I've read the docs and/or content style guides.
  • Words are spelled using American English
  • Use relative URLs for internal links
  • I've checked the pages added or changed in the Vercel preview build
  • If I moved a page, I added a redirect in vercel.json

Created with PostHog Code from an inbox report.

Initialize `siteSettings`, `isMobile`, and `compact` from server-rendered
defaults so the first client render matches the SSR markup exactly. The real
browser-derived values (window.__theme, localStorage, viewport, iframe
embedding) are now applied in a post-mount useEffect instead of being read
during the initial render.

This removes the SSR/client divergence at the source and eliminates the
"Minified React error #418" hydration mismatch that fired for every dark-mode,
mobile, or iframe-embedded visitor.

Generated-By: PostHog Code
Task-Id: 0abc2794-f3af-45f9-b242-b899a57c4b7b
@github-actions

github-actions Bot commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview

Status Details Updated (UTC)
🟢 Ready View preview Jun 16, 2026 03:11AM

@github-actions

Copy link
Copy Markdown
Contributor

Bundle report

Total JS (gzip)

6.30 MiB (+0.4 KiB / +0.0%)

Eager graph (static-import closure per entrypoint)

Entrypoint Eager size Budget Modules
✅ app 29.32 MiB (+20.4 KiB / +0.1%) report-only 5729
Largest modules in the app closure
Module Size
./node_modules/.pnpm/mapbox-gl@3.16.0/node_modules/mapbox-gl/dist/mapbox-gl.js 1619.1 KiB
./src/mdxGlobalComponents.js + 138 modules 868.2 KiB
css ./node_modules/.pnpm/css-loader@5.2.7_webpack@5.101.3/node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[1]!./node_modules/.pnpm/postcss-loader@4.3.0_postcss@8.5.6_webpack@5.101.3/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[2]!./src/styles/global.css 710.1 KiB
./src/components/Stickers/Stickers.tsx 696.4 KiB
./node_modules/.pnpm/lottie-web@5.13.0/node_modules/lottie-web/build/player/lottie.js 610.8 KiB
./node_modules/.pnpm/@radix-ui+react-icons@1.3.2_react@18.3.1/node_modules/@radix-ui/react-icons/dist/react-icons.esm.js 481.4 KiB
./.cache/caches/gatsby-plugin-mdx/mdx-scopes-dir/31a094f140f119e73085d847ae81b99b.js + 2 modules 470.3 KiB
./node_modules/.pnpm/@codemirror+view@6.38.2/node_modules/@codemirror/view/dist/index.js 458.1 KiB
./node_modules/.pnpm/rehype-raw@7.0.0/node_modules/rehype-raw/lib/index.js + 29 modules 395.1 KiB
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.cjs.js 364.8 KiB
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js 354.8 KiB
./src/hooks/useCustomers.tsx + 54 modules 352.3 KiB
./node_modules/.pnpm/react-markdown@8.0.7_@types+react@16.14.66_react@18.3.1/node_modules/react-markdown/lib/react-markdown.js + 88 modules 351.4 KiB
./node_modules/.pnpm/jspdf@3.0.2/node_modules/jspdf/dist/jspdf.es.min.js 334.1 KiB
./node_modules/.pnpm/cloudinary-core@2.14.0_lodash@4.17.21/node_modules/cloudinary-core/cloudinary-core.js 281.9 KiB

Eager-graph budgets are report-only until a baseline is established. Sizes are gzip of public/**/*.js; eager size is webpack module source bytes.

@github-actions

Copy link
Copy Markdown
Contributor

This PR hasn't seen activity in two weeks! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the stale label – otherwise this will be closed in another week. If you want to permanently keep it open, use the waiting label.

@github-actions github-actions Bot added the stale This pull request has been marked as stale and will be closed soon automatically label Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@github-actions github-actions Bot closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This pull request has been marked as stale and will be closed soon automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants