Repository navigation
Fix React #418 hydration mismatch in App context - #17642
Closed
posthog[bot] wants to merge 1 commit into
Closed
posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
Initialize `siteSettings`, `isMobile`, and `compact` from server-rendered defaults so the first client render matches the SSR markup exactly. The real browser-derived values (window.__theme, localStorage, viewport, iframe embedding) are now applied in a post-mount useEffect instead of being read during the initial render. This removes the SSR/client divergence at the source and eliminates the "Minified React error #418" hydration mismatch that fired for every dark-mode, mobile, or iframe-embedded visitor. Generated-By: PostHog Code Task-Id: 0abc2794-f3af-45f9-b242-b899a57c4b7b
Contributor
Deploy preview
|
Contributor
Bundle reportTotal JS (gzip)6.30 MiB (+0.4 KiB / +0.0%) Eager graph (static-import closure per entrypoint)
Largest modules in the
|
| Module | Size |
|---|---|
./node_modules/.pnpm/mapbox-gl@3.16.0/node_modules/mapbox-gl/dist/mapbox-gl.js |
1619.1 KiB |
./src/mdxGlobalComponents.js + 138 modules |
868.2 KiB |
css ./node_modules/.pnpm/css-loader@5.2.7_webpack@5.101.3/node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[1]!./node_modules/.pnpm/postcss-loader@4.3.0_postcss@8.5.6_webpack@5.101.3/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[2]!./src/styles/global.css |
710.1 KiB |
./src/components/Stickers/Stickers.tsx |
696.4 KiB |
./node_modules/.pnpm/lottie-web@5.13.0/node_modules/lottie-web/build/player/lottie.js |
610.8 KiB |
./node_modules/.pnpm/@radix-ui+react-icons@1.3.2_react@18.3.1/node_modules/@radix-ui/react-icons/dist/react-icons.esm.js |
481.4 KiB |
./.cache/caches/gatsby-plugin-mdx/mdx-scopes-dir/31a094f140f119e73085d847ae81b99b.js + 2 modules |
470.3 KiB |
./node_modules/.pnpm/@codemirror+view@6.38.2/node_modules/@codemirror/view/dist/index.js |
458.1 KiB |
./node_modules/.pnpm/rehype-raw@7.0.0/node_modules/rehype-raw/lib/index.js + 29 modules |
395.1 KiB |
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.cjs.js |
364.8 KiB |
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
354.8 KiB |
./src/hooks/useCustomers.tsx + 54 modules |
352.3 KiB |
./node_modules/.pnpm/react-markdown@8.0.7_@types+react@16.14.66_react@18.3.1/node_modules/react-markdown/lib/react-markdown.js + 88 modules |
351.4 KiB |
./node_modules/.pnpm/jspdf@3.0.2/node_modules/jspdf/dist/jspdf.es.min.js |
334.1 KiB |
./node_modules/.pnpm/cloudinary-core@2.14.0_lodash@4.17.21/node_modules/cloudinary-core/cloudinary-core.js |
281.9 KiB |
Eager-graph budgets are report-only until a baseline is established. Sizes are gzip of public/**/*.js; eager size is webpack module source bytes.
Contributor
|
This PR hasn't seen activity in two weeks! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the |
Contributor
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
getInitialSiteSettingsinsrc/context/App.tsxread browser-only state (window.__theme,localStorage,window.innerWidth, iframe detection) during the initial render, so the first client render disagreed with the server-rendered markup for every dark-mode, mobile, or iframe-embedded visitor. React detected the divergence and emitted Minified React error #418 (a hydration mismatch) — ~4.7M occurrences across ~282K users in the last 30 days.This change makes the first client render identical to the server output:
SERVER_SITE_SETTINGSconstant (what the server renders with) and agetClientSiteSettingshelper that reads real browser state.siteSettings,isMobile, andcompactnow initialize from the server-rendered defaults.useEffectapplies the real browser-derived values after hydration completes, so React only re-renders client-side (no mismatch).The server already rendered in light/desktop mode for everyone, so affected users already received that markup and re-rendered — this just turns that into a clean
setStatere-render instead of a hydration-error-triggered one, removing the error-tracking noise without changing the end-state UX. ThesuppressHydrationWarningband-aid atAppWindow/index.tsx:611is left in place but is no longer load-bearing.Why
The #418 hydration mismatch was one of the highest-volume errors on the site (4,710,606 occurrences / 281,983 users in 30 days), flooding error tracking and burning ingestion volume even though React silently recovered. Fixing the SSR/client state divergence at the source eliminates the errors rather than suppressing them per-window.
Checklist
vercel.jsonCreated with PostHog Code from an inbox report.