Repository navigation
Fix site-wide React hydration mismatch (#418) from client-only initial state - #17799
Closed
posthog[bot] wants to merge 1 commit into
Closed
posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
…l state getInitialSiteSettings seeded the App Provider's useState directly from client-only values during render — window.__theme, localStorage siteSettings, and window.innerWidth (which flips experience to 'boring' on mobile). On the server these resolve to defaults, so the first client render diverged from the SSR HTML and React threw hydration error #418 across essentially every marketing path. Initialize siteSettings and isMobile with SSR-safe defaults so the first client render matches the server, then apply the real theme, mobile, and saved siteSettings after mount in a useEffect. The post-hydration appearance is unchanged; the visual theme is still applied pre-hydration by theme-init.js via document.body, so there's no theme flash. Generated-By: PostHog Code Task-Id: f4ff2ffe-955b-4b3f-9578-4dc6891dcdf8
Contributor
Deploy preview
|
Contributor
Bundle reportTotal JS (gzip)6.21 MiB (+0.2 KiB / +0.0%) Eager graph (static-import closure per entrypoint)
Largest modules in the
|
| Module | Size |
|---|---|
css ./node_modules/.pnpm/css-loader@5.2.7_webpack@5.101.3/node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[1]!./node_modules/.pnpm/postcss-loader@4.3.0_postcss@8.5.6_webpack@5.101.3/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[2]!./src/styles/global.css |
709.9 KiB |
./src/components/Stickers/Stickers.tsx |
696.4 KiB |
./.cache/caches/gatsby-plugin-mdx/mdx-scopes-dir/31a094f140f119e73085d847ae81b99b.js + 2 modules |
510.2 KiB |
./node_modules/.pnpm/@radix-ui+react-icons@1.3.2_react@18.3.1/node_modules/@radix-ui/react-icons/dist/react-icons.esm.js |
481.4 KiB |
./node_modules/.pnpm/@codemirror+view@6.38.2/node_modules/@codemirror/view/dist/index.js |
458.1 KiB |
./node_modules/.pnpm/rehype-raw@7.0.0/node_modules/rehype-raw/lib/index.js + 29 modules |
395.1 KiB |
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.cjs.js |
364.8 KiB |
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
354.8 KiB |
./src/hooks/useCustomers.tsx + 54 modules |
353.9 KiB |
./node_modules/.pnpm/react-markdown@8.0.7_@types+react@16.14.66_react@18.3.1/node_modules/react-markdown/lib/react-markdown.js + 88 modules |
351.4 KiB |
./node_modules/.pnpm/cloudinary-core@2.14.0_lodash@4.17.21/node_modules/cloudinary-core/cloudinary-core.js |
281.9 KiB |
./node_modules/.pnpm/@codesandbox+sandpack-react@2.20.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@codesandbox/sandpack-react/dist/index.mjs |
266.6 KiB |
./src/components/ProductComparisonTable/index.tsx + 114 modules |
264.0 KiB |
./node_modules/.pnpm/d3@7.9.0/node_modules/d3/src/index.js + 208 modules |
247.4 KiB |
./src/components/Pricing/PricingSlider/Slider.tsx + 87 modules |
239.9 KiB |
Eager-graph budgets are report-only until a baseline is established. Sizes are gzip of public/**/*.js; eager size is webpack module source bytes.
Contributor
|
This PR hasn't seen activity in two weeks! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the |
Contributor
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a site-wide React hydration mismatch (minified React error #418) that fired on first render across essentially every marketing page — the homepage,
/pricing,/careers,/replay-vision, docs, and more — degrading interactivity on the primary conversion funnel and flooding error tracking (2.7M$exceptionevents from ~135k persons in 14 days).Root cause:
getInitialSiteSettingsinsrc/context/App.tsxseeded the AppProvider'suseStatedirectly from client-only values during render —window.__theme,localStoragesiteSettings, andwindow.innerWidth(which flipsexperienceto'boring'on mobile). On the server these resolve to defaults (light theme, desktop,'posthog'experience), so the first client render diverged from the SSR HTML and React threw #418.Fix: Initialize
siteSettingsandisMobilewith SSR-safe defaults so the first client render matches the server HTML, then apply the real theme,isMobile,compact, and savedsiteSettingsafter mount in auseEffect. The post-hydration appearance is unchanged — the visual theme is still applied pre-hydration bystatic/scripts/theme-init.jsviadocument.body, so there's no theme flash.Why: A single site-wide hydration defect was generating millions of exception events and drowning error tracking in noise while degrading interactivity on the main conversion funnel.
Checklist
vercel.jsonCreated with PostHog Code from an inbox report.