Repository navigation
Load a Korean webfont for /ko - #20286
Closed
posthog[bot] wants to merge 1 commit into
Closed
posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
The Korean pages shipped no Korean webfont, so Hangul rendered from whatever font the visitor's device had. RoundHog (the body face) and Squeak (the display face) contain no Korean glyphs, so every Hangul character on /ko fell through to the generic sans-serif fallback. Add the self-hosted IBM Plex Sans KR Korean subset (400 and 700) and put it ahead of the generic fallback in the four stacks whose named faces have no Hangul: rounded, squeak, nav, and button. The unicode-range on each @font-face limits the files to Hangul syllables and compatibility jamo, so pages with no Korean text declare the faces but download nothing. Generated-By: PostHog Desktop Task-Id: 156e99b8-401c-4d1f-9176-cc2b57e2d997
Contributor
Author
Contributor
Deploy preview
|
Contributor
Bundle reportTotal JS (gzip)8.66 MiB (+0.0 KiB / +0.0%) Eager graph (modules shipped in each entrypoint's initial chunks)
Largest modules in the
|
| Module | Size |
|---|---|
./src/data/mcp-tools.json |
1157.5 KiB |
css ./node_modules/.pnpm/css-loader@5.2.7_webpack@5.101.3/node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[1]!./node_modules/.pnpm/postcss-loader@4.3.0_postcss@8.5.6_webpack@5.101.3/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[2]!./src/styles/global.css |
773.2 KiB |
./src/components/Stickers/Stickers.tsx |
696.4 KiB |
./node_modules/.pnpm/@radix-ui+react-icons@1.3.2_react@18.3.1/node_modules/@radix-ui/react-icons/dist/react-icons.esm.js |
481.4 KiB |
./node_modules/.pnpm/@posthog+brand@0.8.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/x-ray.mjs |
480.8 KiB |
./node_modules/.pnpm/rehype-raw@7.0.0/node_modules/rehype-raw/lib/index.js + 29 modules |
395.1 KiB |
./node_modules/.pnpm/@posthog+brand@0.8.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/im-the-driver.mjs |
385.7 KiB |
./src/hooks/useCustomers.tsx + 55 modules |
372.5 KiB |
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
354.8 KiB |
./node_modules/.pnpm/react-markdown@8.0.7_@types+react@16.14.66_react@18.3.1/node_modules/react-markdown/lib/react-markdown.js + 88 modules |
351.4 KiB |
./src/components/ProductComparisonTable/index.tsx + 126 modules |
305.8 KiB |
./node_modules/.pnpm/cloudinary-core@2.14.0_lodash@4.17.21/node_modules/cloudinary-core/cloudinary-core.js |
281.9 KiB |
./node_modules/.pnpm/@posthog+brand@0.8.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/doll-house.mjs |
281.7 KiB |
./node_modules/.pnpm/@posthog+brand@0.8.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/director.mjs |
275.6 KiB |
./src/components/SearchUI/index.tsx + 87 modules |
273.7 KiB |
Eager-graph budgets are report-only until a baseline is established. Sizes are gzip of public/**/*.js; eager size is webpack module source bytes for the modules actually shipped in the entrypoint's initial chunks (post-tree-shake).
Contributor
|
This PR hasn't seen activity in two weeks! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
/koshipped no Korean webfont, so every Hangul character rendered from whatever font the visitor's device had. A renderer without Korean coverage shows the page as blocks or bars.RoundHog(the body face) andSqueak(the display face) contain no Korean glyphs, so all Hangul on/kofell straight through to the genericsans-seriffallback. Measured on the running page: all 123 Hangul text nodes resolve through one stack,rounded.unicode-rangelimits each face to Hangul syllables and compatibility jamo, so pages with no Korean text declare the faces and download nothing.rounded(body)RoundHog, sans-serifRoundHog, IBM Plex Sans KR, sans-serifsqueakSqueak, sans-serifSqueak, IBM Plex Sans KR, sans-serifnavIBM Plex Sans Variable, IBM Plex Sans, sans-serif…, IBM Plex Sans KR, sans-serifbuttonIBM Plex Sans Variable, IBM Plex Sans, sans-serif…, IBM Plex Sans KR, sans-serifsans,matter, andosare left alone. Their leading entries are system faces, and/kodoes not use them.Cost
IBM Plex Sans KRfaces/unloaded/koloaded(400 and 700)font-display: swapBoth rows are measured in the browser, not estimated. The English homepage fetches no Korean file.
Hangul rendering
The sandbox browser falls back to a Chinese face, which is why the "before" column is readable but wrong: different letter shapes, different metrics, different line breaks. That is the point — the shapes depend on the client, not on us.
Full
/kogrid — light and dark, narrow (640) and wide (1440)Note
The report also named React #418 and #423 hydration errors on
/ko. Those are site-wide, not Korean — the per-session rate matches/. This PR does not touch them.Checklist
vercel.json— no page movedAgent context — what I checked and what I rejected
Verified locally with
gatsby developand headless Chromium on/ko:document.fontslistsIBM Plex Sans KRasloadedon/koandunloadedon/, and the network log shows the two woff2 files on/koonly.pnpm prettierclean on every changed file. No page moved, sopnpm test-redirectsdoes not apply.Rejected approaches
400.css)@font-facerules per weight in the site-wide stylesheet, paid by every visitorApple SD Gothic Neo,Malgun Gothic)/kouses onlyrounded, so the rest is dead weightsrc/html.tsxhtml.tsxis global, so every visitor would fetch ~1 MBNote on the lockfile.
pnpm addcannot resolve in a clean checkout here:trustPolicy: no-downgradeinpnpm-workspace.yamlrejects a dozen packages already in the lockfile (@headlessui/react,tailwindcss,react-reduxand more), and each failure stops the resolve. The threepnpm-lock.yamlentries are therefore written by hand, with the integrity hash read from the registry and confirmed against the downloaded tarball.pnpm install --frozen-lockfilethen installs the package and passes.Created with PostHog Desktop from this inbox report.
Origin
d650f81