Skip to content

feat(oauth): ask users to keep or disconnect unverified partners on first login - #117756

Merged
trunk-io[bot] merged 3 commits into
masterfrom
matt/provisioning-claim-consent
Oct 16, 2026
Merged

trunk-io[bot] merged 3 commits into
masterfrom
matt/provisioning-claim-consent

Conversation

@MattBro

@MattBro MattBro commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem

  • When a partner PostHog hasn't verified creates someone's PostHog organization, the person's first login lists that partner's access, but "Continue" keeps it connected by default.
  • That means a person can start using an account an unverified app set up without ever saying they want that app to keep access.

Changes

  • On the first-login credential review, each unverified partner that set up one of the user's organizations gets a card: "{App} set up your PostHog organization and has access to your account. Keep it connected only if you asked {App} to do this." The card has "Keep connected" and "Disconnect" buttons.
  • The app moves out of the connected applications table into that card, so its scopes no longer show on this screen.
  • Continue stays disabled until every such app has a choice, and while a disconnect is in flight. If the connected apps list fails to load, Continue stays disabled with "Could not load your connected apps. Reload the page to try again."
  • Disconnect is disabled while the review saves.
  • Disconnect uses the existing connected apps revoke endpoint. The app then drops off the list.
  • Verified partners, first-party apps, personal API keys and passkeys look and behave as before.
  • The connected apps API gains requires_access_confirmation. It is true only when the app set up one of the user's organizations (an OrganizationProvisioning row), isn't verified, and isn't first-party.
  • credentials_review_complete is unchanged, so an older frontend keeps today's behavior and the server never revokes anything on its own.
  • New event: credential review partner access chosen, with choice and application_id.
  • Mechanical: the connected apps endpoints are now in the OpenAPI spec (internal), so connectedAppsLogic uses generated types and the handwritten ConnectedApp interface is gone. A revoke that returns 404 reloads the list.

Screenshots come from the Scenes-Other/Credential Review story. The before renders master's components with the same story data.

Before: the unverified app sits in the connected applications table, and Continue works without a choice.

credential-review-before

After: the app gets its own card, and Continue stays disabled until the user chooses.

credential-review-after

After "Keep connected": the button shows a check, and Continue is enabled.

credential-review-after-kept

How did you test this code?

  • posthog/api/oauth/test_connected_apps.py: the new field is parameterized over set up by the app, verified, first-party, switched off after setup, authorized directly with no setup row, and an org the user doesn't belong to.
  • Jest: credentialReviewLogic.test.ts and connectedAppsLogic.test.ts cover Continue blocked until each unverified partner has a choice, Disconnect calling revoke, Disconnect ignored while the review saves, a failed list load blocking Continue, and a 404 on revoke reloading the list.
  • typescript:check passes.
  • Each new test failed when its part of the change was reverted.
  • Not run: the screen in a running app with a real partner-provisioned account.

Test rationale: the connected apps API test and the existing credential review logic tests were extended. The backend cases pin the rule that selects which apps need a choice; the logic tests pin that Continue cannot skip the choice.

Release status

  • No feature flag controls this change

Docs update

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Claude Opus 5.5

  • Built in a multi-agent workflow: an implementer, an adversarial reviewer, then a fix pass. The review narrowed the selection rule from "any provisioning app" to "an unverified app that set up the user's organization", and made a failed app list block Continue instead of skipping the choice.
  • Skills invoked: /writing-ui-components, /writing-kea-logics, /adopting-generated-api-types, /writing-tests, /writing-user-facing-copy, /writing-pr-descriptions.
  • The desktop API client wasn't regenerated locally (generator not installed); CI regenerates it.
  • Public artifact: no session material in the diff.

🤖 Generated with Claude Code

…irst login

The first-login credential review now lists each unverified partner that set
up one of the user's organizations, and the user must choose to keep it
connected or disconnect it before continuing. Disconnect uses the existing
revoke path. Verified partners, personal API keys and passkeys are unchanged,
and the server keeps today's behavior for clients that send no choice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MattBro MattBro self-assigned this Oct 15, 2026
@trunk-io

trunk-io Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

✅ Complexity (TypeScript) — clean

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

⚠️ Duplication (TypeScript) — 1 new duplicated block (worst 95 tokens)

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

First copy Second copy Lines Tokens
frontend/src/scenes/authentication/account/credential-review/credentialReviewLogic.ts:37 frontend/src/scenes/settings/user/connectedAppsLogic.ts:18 27 95
⚠️ Bundle size — 🔺 +57.6 KiB (+0.1%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 76.70 MiB · 🔺 +57.6 KiB (+0.1%)

File Size Δ vs base
render-query/src/render-query/render-query.js 24.61 MiB 🔺 +9.3 KiB (+0.0%)
posthog-app/_parent/products/business_intelligence/frontend/BusinessIntelligenceScene.js 147.4 KiB 🔺 +3.3 KiB (+2.3%)
posthog-app/src/scenes/authentication/account/credential-review/CredentialReview.js 8.9 KiB 🔺 +3.2 KiB (+55.2%)
posthog-app/_parent/products/workflows/frontend/WorkflowsScene.js 59.6 KiB 🔺 +3.1 KiB (+5.6%)
posthog-app/src/scenes/experiments/Experiment.js 310.9 KiB 🔺 +1.0 KiB (+0.3%)

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1013.3 KiB · 24 files 🔺 +978 B (+0.1%) █████████░ 86.5% of 1.14 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login)
src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
2.88 MiB · 607 files 🔺 +1.9 KiB (+0.1%) █████████░ 94.9% of 3.03 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
7.47 MiB · 2,538 files 🔺 +7.1 KiB (+0.1%) ██████████ 97.7% of 7.64 MiB
dashboard scene
src/scenes/dashboard/Dashboard.tsx
9.67 MiB · 3,624 files 🔺 +8.0 KiB (+0.1%) █████████░ 93.9% of 10.30 MiB
today home path
src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
7.86 MiB · 2,869 files 🔺 +8.7 KiB (+0.1%) ██████████ 99.6% of 7.89 MiB
events scene
src/scenes/activity/explore/EventsScene.tsx
9.24 MiB · 3,451 files 🔺 +7.8 KiB (+0.1%) █████████░ 93.6% of 9.88 MiB
replay detail scene
src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
11.98 MiB · 4,296 files 🔺 +10.1 KiB (+0.1%) ████████░░ 79.6% of 15.05 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/zod/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/billing/billingLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/ProductEmptyState/productSetupPreloadLogic.ts stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/dashboards/frontend/widgets/previews/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 zod/v4/locales/de.js stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/today/TodayReportPage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/activity/explore/EventsScene.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/index.tsx
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
904 B src/lib/utils/bootTiming.ts
Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
220.2 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.9 KiB src/products.tsx
99.6 KiB src/lib/api.ts
69.0 KiB src/lib/lemon-ui/icons/icons.tsx
38.7 KiB ../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js
33.9 KiB ../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js
28.9 KiB src/scenes/scenes.ts
27.8 KiB src/lib/constants.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.2 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
139.9 KiB ../packages/quill/packages/primitives/dist/index.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.9 KiB src/products.tsx
99.6 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.2 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
181.9 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
139.9 KiB ../packages/quill/packages/primitives/dist/index.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.9 KiB src/products.tsx
99.6 KiB src/lib/api.ts
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.2 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
139.9 KiB ../packages/quill/packages/primitives/dist/index.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.9 KiB src/products.tsx
99.6 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.2 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
181.9 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
139.9 KiB ../packages/quill/packages/primitives/dist/index.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.9 KiB src/products.tsx
99.6 KiB src/lib/api.ts
Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
316.0 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.2 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
181.9 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.9 KiB src/products.tsx
99.6 KiB src/lib/api.ts

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

✅ Toolbar bundle — eager 2.24 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric Size Δ vs base Budget
Eager (shipped)
entry + static imports
2.24 MiB · 19 files 🟢 -122 B (-0.0%) ████░░░░░░ 39.1% of 5.72 MiB
Deferred (lazy) 2.10 MiB · 40 files no change n/a — loads on demand
Loader dist/toolbar.js 1.2 KiB no change █░░░░░░░░░ 6.0% of 19.5 KiB
Largest eagerly-shipped chunks
Size File
877.1 KiB dist/toolbar/toolbar-app-I7G2FM3L.css
664.1 KiB dist/toolbar/chunk-chunk-LCKMNCQD.js
257.8 KiB dist/toolbar/chunk-chunk-7ZYWOYNH.js
131.8 KiB dist/toolbar/chunk-chunk-FDH2IBXT.js
129.6 KiB dist/toolbar/chunk-chunk-Z3WV3VUI.js
74.7 KiB dist/toolbar/toolbar-app-5TLDIVGF.js
69.0 KiB dist/toolbar/chunk-chunk-TSAL54PB.js
35.6 KiB dist/toolbar/chunk-chunk-H3YX7NLE.js
21.7 KiB dist/toolbar/chunk-chunk-UENEKWYB.js
6.8 KiB dist/toolbar/chunk-chunk-DV7IWQNF.js

Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile

✅ Dist folder size — 🔺 +460.8 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1017.16 MiB · 🔺 +460.8 KiB (+0.0%)

⚠️ Playwright — 1 flaky

🎭 Playwright report · View test results →

⚠️ 1 flaky test:

  • Materialize view pane (chromium)

These issues are not necessarily caused by your changes.
Annoyed by this section? Help fix flakies and failures and it will go green!

✅ Hogbox preview — ready, open the preview

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds: a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit 1218afe · box box-719c7a50abfe · ready in 1251s (push → usable) · build log · rebuilds on every push, torn down on close

@posthog posthog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostHog Review · Standard · reviewed 9a868ea: 1 Should fix.

This is the only automatic review while this pull request is a draft. Comment @posthog review to review new changes sooner. Otherwise, a review of the new changes runs when you mark it ready for review.

@trunk-io

trunk-io Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

… saves

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MattBro
MattBro marked this pull request as ready for review October 15, 2026 16:21
@parameterai

parameterai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Risk: No findings

This change adds a first-login confirmation step for unverified partner apps that provisioned the user's organization: the connected-apps API gains a requires_access_confirmation flag (unverified, non-first-party app with live tokens that created one of the user's orgs), and the credential-review screen blocks Continue until the user picks "Keep connected" or "Disconnect" (revoke) for each such app. The backend flag is correctly user-scoped, the revoke endpoint filters by the requesting user's own tokens (no IDOR), and the destructive revoke path keeps SessionAuthentication plus TimeSensitiveActionPermission. I found no security vulnerabilities introduced by this change.

Sentinel reviewed fa251a3 · Review settings

@posthog

posthog Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

✅ Visual changes approved by @MattBro — baseline updated in 1218afe.

View this run in PostHog

4 changed.

Install the Visual Review Chrome extension to see visual review results at the top of your pull requests.

4 updated
Run: 06a2f2c0-af3a-469e-b0bc-6fa33018b3b7

Co-authored-by: MattBro <9833550+MattBro@users.noreply.github.com>
@MattBro

MattBro commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

/trunk merge

@trunk-io
trunk-io Bot merged commit 75d6ea4 into master Oct 16, 2026
@trunk-io
trunk-io Bot deleted the matt/provisioning-claim-consent branch October 16, 2026 20:18
@deployment-status-posthog

deployment-status-posthog Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-10-16 20:46 UTC Run
prod-us ✅ Deployed 2026-10-16 21:06 UTC Run
prod-eu ✅ Deployed 2026-10-16 21:07 UTC Run

This branch was successfully deployed

1 active deployment
hogbox-preview — 1218afe4 Deployed Oct 15, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants