Skip to content

Update wording for runEvery functions in PluginEditor - #4315

Merged
neilkakkar merged 2 commits into
masterfrom
neilkakkar-patch-1
May 12, 2021
Merged

neilkakkar merged 2 commits into
masterfrom
neilkakkar-patch-1

Conversation

@neilkakkar

Copy link
Copy Markdown
Contributor

There's a distributed lock across plugin servers that ensures only one server gets the task ( https://github.com/PostHog/plugin-server/blob/master/src/main/services/schedule.ts#L43 ), and piscina enqueues the task only once, which ensures only one worker in a server gets it (https://github.com/PostHog/plugin-server/blob/master/src/main/services/schedule.ts#L94-L103)

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

There's a distributed lock across plugin servers that ensures only one server gets the task ( https://github.com/PostHog/plugin-server/blob/master/src/main/services/schedule.ts#L43 ), and piscina enqueues the task only once, which ensures only one worker in a server gets it (https://github.com/PostHog/plugin-server/blob/master/src/main/services/schedule.ts#L94-L103)
@neilkakkar
neilkakkar requested a review from yakkomajuri May 12, 2021 10:52
@timgl
timgl temporarily deployed to posthog-pr-4315 May 12, 2021 10:55 Inactive
@yakkomajuri
yakkomajuri temporarily deployed to posthog-pr-4315 May 12, 2021 12:07 Inactive
@yakkomajuri

yakkomajuri commented May 12, 2021 •

Copy link
Copy Markdown
Contributor

Good spot!

I went in to make "instance" plural, but ended up making a few other copy edits. See what you think and feel free to disagree. I think we don't need to worry the user with stuff about how our workers are set up, let's just tell them it will run once and that should be fine.

@neilkakkar

Copy link
Copy Markdown
Contributor Author

ha, even better!

I'm guessing there's something weird going on with the Cypress tests? Flaky?

@yakkomajuri

Copy link
Copy Markdown
Contributor

It's a constant battle with Cypress - feel free to merge

@neilkakkar
neilkakkar merged commit 2985bc3 into master May 12, 2021
@neilkakkar
neilkakkar deleted the neilkakkar-patch-1 branch May 12, 2021 14:06

This branch was previously deployed

1 inactive deployment
posthog-pr-4315 — 1f30e8d8 Deployed May 12, 2021 by yakkomajuri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants