Skip to content

Step time conversions for Unordered funnels - #5024

Merged
neilkakkar merged 4 commits into
masterfrom
unordered_time_conversions
Jul 7, 2021
Merged

neilkakkar merged 4 commits into
masterfrom
unordered_time_conversions

Conversation

@neilkakkar

Copy link
Copy Markdown
Contributor

Changes

Resolves #5003

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar
neilkakkar requested review from EDsCODE and Twixes July 7, 2021 11:21
@timgl
timgl temporarily deployed to posthog-pr-5024 July 7, 2021 11:22 Inactive

@Twixes Twixes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@timgl
timgl temporarily deployed to posthog-pr-5024 July 7, 2021 15:08 Inactive
@neilkakkar
neilkakkar enabled auto-merge (squash) July 7, 2021 15:12
@neilkakkar
neilkakkar merged commit 7d5e8a7 into master Jul 7, 2021
@neilkakkar
neilkakkar deleted the unordered_time_conversions branch July 7, 2021 15:18

This branch was previously deployed

1 inactive deployment
posthog-pr-5024 — 9f072852 Deployed Jul 7, 2021 by timgl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get Strict and Unordered Funnels to return appropriate step conversion times

3 participants