Skip to content

[CI] (137243f) python/meeting-summarizer - #1968

Closed
wizard-ci-bot[bot] wants to merge 1 commit into
mainfrom
wizard-ci-137243f-python-meeting-summarizer
Closed

wizard-ci-bot[bot] wants to merge 1 commit into
mainfrom
wizard-ci-137243f-python-meeting-summarizer

Conversation

@wizard-ci-bot

@wizard-ci-bot wizard-ci-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

Automated wizard CI run

Source: wizard-pr
Trigger ID: 137243f
App: python/meeting-summarizer
App directory: apps/python/meeting-summarizer
Workbench branch: wizard-ci-137243f-python-meeting-summarizer
Wizard branch: release-please--branches--main--components--wizard
Context Mill branch: main
PostHog (MCP) branch: master
Timestamp: 2026-06-18T16:26:42.046Z
Duration: 479.1s

@wizard-ci-bot

wizard-ci-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown
Author

Now I have enough context. Let me produce the evaluation.


PR Evaluation Report

Summary

This PR integrates PostHog analytics into a Python meeting-summarizer web application. A new posthog_client.py module initializes the SDK, and server.py and user_service.py are instrumented with capture and person property calls across login, logout, meeting, and user management flows.

Files changed Lines added Lines removed
6 +137 -2

Confidence score: 4/5 👍

  • PII in login_failed event: The distinct_id for the login_failed event is the raw email address. This sends PII as the distinct_id, polluting person data with email-based anonymous profiles. Should use a hashed or anonymized value, or omit distinct_id entirely. [CRITICAL]
  • username sent as person property via set(): Username is set via posthog_client.set() with properties={'username': user.username} in multiple places. While username is less sensitive than email, it's borderline PII and is consistently the only person property set — no other useful properties are captured on person profiles. [LOW]
  • No .env.example file committed: The PR adds .gitignore for .env but does not create or update a .env.example file documenting POSTHOG_PROJECT_TOKEN and POSTHOG_HOST. The report even calls this out as a TODO. [MEDIUM]
  • Context/session only used in login path: The new_context(), identify_context(), and set_context_session() pattern is only applied in the login handler. All other capture calls use bare posthog_client.capture() with explicit distinct_id, missing the benefit of context-based tagging and session linking for non-login events. [LOW]

File changes

Filename Score Description
posthog_client.py 4/5 Clean SDK initialization with env vars, exception autocapture, and atexit shutdown registration. Solid pattern.
server.py 3/5 Captures events across all major endpoints. PII issue with login_failed using email as distinct_id. Context pattern only used for login.
user_service.py 4/5 Clean instrumentation of register and deactivate flows with appropriate properties.
requirements.txt 4/5 Adds posthog and python-dotenv dependencies correctly.
.gitignore 5/5 Properly ignores .env file.
posthog-setup-report.md 4/5 Thorough report documenting events and next steps.

App sanity check ⚠️

Criteria Result Description
App builds and runs Yes Dependencies are valid, imports resolve, no syntax issues
Preserves existing env vars & configs Yes Only adds new imports and PostHog calls; existing logic untouched
No syntax or type errors Yes All code is syntactically valid Python
Correct imports/exports Yes posthog_client imported correctly; identify_context and set_context_session imported from posthog module
Minimal, focused changes Yes All changes relate to PostHog integration
Pre-existing issues None —

Issues

  • No .env.example: Environment variables POSTHOG_PROJECT_TOKEN and POSTHOG_HOST are not documented in a .env.example file. New developers won't know what to set. [MEDIUM]

Other completed criteria

  • Build configuration (requirements.txt) is valid and parseable
  • Code follows existing codebase patterns (guard checks with if posthog_client:, consistent indentation)
  • All imports are valid and from correct packages

PostHog implementation ⚠️

Criteria Result Description
PostHog SDKs installed Yes posthog>=3.0.0 added to requirements.txt
PostHog client initialized Yes Instance-based Posthog() constructor in posthog_client.py with enable_exception_autocapture=True and atexit.register(posthog_client.shutdown)
capture() Yes 10 meaningful capture calls across login, logout, meeting, and user management flows
identify() N/A Server-only app
Error tracking Yes enable_exception_autocapture=True set in constructor
Reverse proxy N/A Server-only app

Issues

  • PII as distinct_id in login_failed: The login_failed event uses the raw email address as distinct_id. This creates orphaned person profiles keyed by email, leaking PII into PostHog. Should use a generic anonymous identifier or omit distinct_id to let the SDK generate one. [CRITICAL]
  • Context pattern inconsistently applied: new_context() / identify_context() / set_context_session() is only used in the login handler. All other endpoints use bare capture() calls with explicit distinct_id, missing session linking. [LOW]

Other completed criteria

  • API key loaded from POSTHOG_PROJECT_TOKEN environment variable (not hardcoded)
  • Host loaded from POSTHOG_HOST environment variable
  • atexit.register(posthog_client.shutdown) ensures events are flushed on exit
  • Graceful handling when env vars are missing (client is None, all calls guarded)

PostHog insights and events ⚠️

Filename PostHog events Description
server.py user_logged_in, login_failed, user_logged_out, meeting_submitted, user_created, user_updated, user_deleted, meeting_deleted Covers full user and meeting lifecycle. meeting_submitted includes rich properties (word count, participant count, etc.). login_failed has PII issue.
user_service.py user_registered, user_deactivated Registration and deactivation events with boolean metadata properties.
posthog_client.py capturedException (autocapture) Exception autocapture enabled for automatic error tracking.

Issues

  • PII in login_failed distinct_id: Email used as distinct_id — this is PII leaking into PostHog person profiles. [CRITICAL]
  • username as person property: posthog_client.set() sets username as a person property. While less sensitive than email, it could be considered PII depending on the app. [LOW]

Other completed criteria

  • Events represent real user actions (login, logout, meeting submission, CRUD operations)
  • Events enable product insights (login→meeting funnel, churn via deletions/deactivations)
  • meeting_submitted includes rich contextual properties (transcript_word_count, participant_count, etc.)
  • Event names are descriptive and use consistent snake_case convention
  • user_registered includes boolean metadata (has_full_name, has_metadata) rather than raw PII

Reviewed by wizard workbench PR evaluator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants