Repository navigation
[CI] (8dccaac) android/Jetchat - #2343
Closed
wizard-ci-bot[bot] wants to merge 1 commit into
Closed
wizard-ci-bot[bot] wants to merge 1 commit into
wizard-ci-bot[bot] wants to merge 1 commit into
Conversation
Author
PR Evaluation ReportSummaryThis PR integrates PostHog analytics into the Jetchat Android (Kotlin/Jetpack Compose) sample app. A new
Confidence score: 3/5 🤔
File changes
App sanity check
|
| Criteria | Result | Description |
|---|---|---|
| App builds and runs | No | PostHog.identify(properties = ...) uses an invalid named parameter — should be userProperties. This is a Kotlin compile error. |
| Preserves existing env vars & configs | Yes | Existing configs and code preserved; only PostHog additions made. |
| No syntax or type errors | No | Wrong named parameter in identify() call is a type/syntax error. |
| Correct imports/exports | Yes | All imports (com.posthog.PostHog, com.posthog.android.*) are correct. |
| Minimal, focused changes | Yes | All changes are PostHog-related with no scope creep. |
| Pre-existing issues | NavActivity missing android:label |
The main activity lacks android:label, which means automatic screen view tracking will fall back to the activity class name. Not introduced by this PR. |
Issues
- Wrong
identify()parameter name:PostHog.identify(distinctId = username, properties = mapOf(...))usespropertieswhich does not exist on the SDK'sidentifymethod. The correct parameter name isuserProperties. This will cause a compile-time error. [CRITICAL] - No
local.properties.examplecommitted: Theposthog.apiKeyandposthog.hostkeys are read fromlocal.propertiesbut no example file is committed to guide collaborators. [MEDIUM]
Other completed criteria
- Build configuration correctly enables
buildConfig = trueand adds the PostHog dependency - Existing app code and functionality preserved — no deletions of meaningful code
- Changes are minimal and focused on PostHog integration only
PostHog implementation ⚠️
| Criteria | Result | Description |
|---|---|---|
| PostHog SDKs installed | Yes | com.posthog:posthog-android:3.+ added to build.gradle.kts dependencies. |
| PostHog client initialized | Yes | PostHogAndroid.setup(this, config) called in JetchatApplication.onCreate() with lifecycle events, screen views, deep links, session replay, and error autocapture enabled. Follows docs pattern exactly. |
| capture() | Yes | 12 distinct PostHog.capture() calls across 6 files covering core user flows. |
| identify() | No | Uses wrong parameter name properties instead of userProperties. Also uses raw username as distinctId, which is fragile and PII-adjacent. |
| Error tracking | Yes | errorTrackingConfig.autoCapture = true enabled in SDK config — correct per docs. |
| Reverse proxy | N/A | Android mobile app — ad blockers do not apply; reverse proxy is not needed. |
Issues
identify()incorrect parameter:PostHog.identify(distinctId = username, properties = mapOf("username" to username))—propertiesis not a valid parameter on the Android SDKidentifymethod. Must useuserProperties. [CRITICAL]- Username as distinct_id: Using a raw username (from fake auth that accepts anything) as
distinctIdis fragile. Two users entering the same username would be merged. A stable internal ID is preferred. [MEDIUM]
Other completed criteria
- API key loaded from
BuildConfig.POSTHOG_API_KEYsourced fromlocal.properties— not hardcoded - Host correctly defaults to
https://us.i.posthog.comvia BuildConfig PostHog.reset()correctly called on logout before clearing state- Session replay enabled via
sessionReplay = true - Autocapture of lifecycle events, screen views, and deep links enabled
PostHog insights and events ⚠️
| Filename | PostHog events | Description |
|---|---|---|
MainViewModel.kt |
user_logged_in, user_logged_out |
Auth flow tracking with identify on login and reset on logout |
Conversation.kt |
message_sent, drag_drop_message_received |
Core messaging actions with channel name and message length |
RecordButton.kt |
voice_recording_started, voice_recording_completed, voice_recording_cancelled |
Voice recording lifecycle funnel |
UserInput.kt |
attachment_selector_opened, emoji_selected |
Input feature engagement with selector type and emoji value |
ProfileFragment.kt |
profile_viewed |
Profile navigation with user ID |
JetchatDrawer.kt |
channel_switched, widget_added_to_home_screen |
Navigation and widget actions |
Issues
- PII in event properties:
user_logged_inincludes"username"incapture()event properties. Usernames are PII and should be set via person properties (e.g.,userPropertiesinidentify()or `` incapture()), not as event-level properties. [MEDIUM]
Other completed criteria
- All 12 events represent real user actions (login, messaging, recording, navigation, etc.)
- Events enable product insights — voice recording funnel, messaging trends, feature engagement, retention via login/logout
- Events include relevant contextual properties (channel name, message length, selector type, emoji, profile user ID)
- Event names follow consistent
snake_caseconvention and are descriptive of the action
Reviewed by wizard workbench PR evaluator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated wizard CI run
Source: wizard-pr
Trigger ID:
8dccaacApp:
android/JetchatApp directory:
apps/android/JetchatWorkbench branch:
wizard-ci-8dccaac-android-JetchatWizard branch:
release-please--branches--main--components--wizardContext Mill branch:
mainPostHog (MCP) branch:
masterTimestamp: 2026-07-03T00:19:12.582Z
Duration: 509.8s
YARA Scanner