Repository navigation
[CI] (8dccaac) javascript-node/native-http-contacts - #2350
Closed
wizard-ci-bot[bot] wants to merge 1 commit into
Closed
wizard-ci-bot[bot] wants to merge 1 commit into
wizard-ci-bot[bot] wants to merge 1 commit into
Conversation
Author
PR Evaluation ReportSummaryThis PR integrates the
Confidence score: 4/5 👍
File changes
App sanity check
|
| Criteria | Result | Description |
|---|---|---|
| App builds and runs | Yes | No syntax errors; posthog-node added to dependencies |
| Preserves existing env vars & configs | Yes | Existing code structure, routes, and logic preserved |
| No syntax or type errors | Yes | All changes are syntactically valid JavaScript |
| Correct imports/exports | Yes | PostHog correctly imported from posthog-node |
| Minimal, focused changes | Yes | All changes relate to PostHog integration |
| Pre-existing issues | .env file with real API key (phc_xxxx...CV6a) exists in the repo (not introduced by this PR) |
Should be gitignored |
Issues
- No
.env.examplefile:POSTHOG_API_KEYandPOSTHOG_HOSTare required but not documented in a.env.example. Collaborators have no reference for required environment variables. [MEDIUM]
Other completed criteria
- App builds without errors — valid JS, dependency added
- Existing routes and logic fully preserved
- Clean imports using the correct server-side SDK package
- Graceful shutdown hooks added for
SIGTERMandSIGINTto flush events
PostHog implementation ⚠️
| Criteria | Result | Description |
|---|---|---|
| PostHog SDKs installed | Yes | posthog-node@^5.39.4 added to package.json |
| PostHog client initialized | Yes | new PostHog(process.env.POSTHOG_API_KEY, { host, enableExceptionAutocapture }) — correct pattern for posthog-node |
| capture() | Yes | 5 capture calls across all mutating routes |
| identify() | N/A | Server-only app |
| Error tracking | Yes | posthog.captureException(err, distinctId) in the catch block; enableExceptionAutocapture: true in config |
| Reverse proxy | N/A | Server-only app |
Issues
- Raw email as
distinct_id:contact_createdusesbody.email, andcontact_updated/contact_deletedusecontact.emailas thedistinctId. These contacts are data subjects, not application users — using their email as distinct_id creates orphan person profiles and leaks PII. All events should use thedistinctIdvariable (from thex-posthog-distinct-idheader) which is already extracted but unused for these routes. [CRITICAL]
Other completed criteria
- API key and host correctly loaded from environment variables
posthog.shutdown()called on SIGTERM/SIGINT for graceful flushenableExceptionAutocaptureis a valid posthog-node config optioncaptureException(err, distinctId)matches the SDK's method signature
PostHog insights and events ⚠️
| Filename | PostHog events | Description |
|---|---|---|
index.js |
group_created |
Tracks group creation with group ID and name |
index.js |
contacts_searched |
Tracks search/filter actions with query, group filter, and result count |
index.js |
contact_created |
Tracks new contact creation with contact details and `` person properties |
index.js |
contact_updated |
Tracks contact updates with updated field names |
index.js |
contact_deleted |
Tracks contact deletion with contact details |
index.js |
captureException |
Captures unhandled errors in the global catch block |
Issues
- PII in event properties:
contact_email(email address) andcontact_name(full name) appear as regular event properties incontact_created,contact_updated, andcontact_deleted. These are PII and must not be incapture()event properties. Thecontact_createdevent already correctly uses `` for person properties — removecontact_emailand `contact_name` from the regular properties in all three events. [CRITICAL]
Other completed criteria
- Events represent real CRUD user actions (create, read/search, update, delete contacts and groups)
- Events enable product insights — can build funnels (group_created → contact_created → contacts_searched), track churn signals via deletions
- Events include enriched properties (result counts, updated field names, boolean flags for optional fields)
- Event names are descriptive, consistent snake_case convention
Reviewed by wizard workbench PR evaluator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated wizard CI run
Source: wizard-pr
Trigger ID:
8dccaacApp:
javascript-node/native-http-contactsApp directory:
apps/javascript-node/native-http-contactsWorkbench branch:
wizard-ci-8dccaac-javascript-node-native-http-contactsWizard branch:
release-please--branches--main--components--wizardContext Mill branch:
mainPostHog (MCP) branch:
masterTimestamp: 2026-07-03T00:26:36.981Z
Duration: 230.8s
YARA Scanner