Skip to content

fix(pr-evaluator): grade Laravel 12+ installs against posthog-laravel - #5058

Open
gewenyu99 wants to merge 1 commit into
mainfrom
fix/evaluator-laravel-sdk-rules
Open

gewenyu99 wants to merge 1 commit into
mainfrom
fix/evaluator-laravel-sdk-rules

Conversation

@gewenyu99

Copy link
Copy Markdown
Contributor

Problem

PostHog/context-mill#497 moves Laravel 12+ installs to posthog/posthog-laravel. The evaluator's vendored commandments.yaml still says to create a PostHogService wrapper and register config by hand, and its php rule says to call PostHog::init(). When the GitHub fetch fails and the evaluator falls back to this copy, it would mark a correct Laravel SDK install as wrong.

Both Laravel apps here (basic-integration/laravel/laravel12-saas and error-tracking/cicd-github-actions-docker-php-laravel) are on Laravel 12, so both get the new setup.

Changes

The runtime fetch from context-mill main already picks up the new rules once the context-mill stack merges. This keeps the fallback in step.

How it was checked

Parsed the file with the evaluator's parsing rules: 6 Laravel rules and 5 PHP rules, with single backslashes in the facade name. Evaluator tests weren't run.

🤖 Generated with Claude Code

The vendored fallback still required a PostHogService wrapper, which the
Laravel SDK replaces. Sync the laravel rules with context-mill and stop the
php rule from asking for PostHog::init() when posthog-laravel is used.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gewenyu99
gewenyu99 requested a review from a team as a code owner November 10, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant