Skip to content

fix: noramlize path for working directory - #1259

Merged
gewenyu99 merged 2 commits into
mainfrom
env-file-blocked
Oct 7, 2026
Merged

gewenyu99 merged 2 commits into
mainfrom
env-file-blocked

Conversation

@edwinyjlim

Copy link
Copy Markdown
Member

Problem

https://us.posthog.com/project/2/support/tickets/72326?assignee=%5B%22role%3A019d8b94-166a-0000-538b-140af1883beb%22%5D

robot comment:

The reported "path traversal" failure was a normalization bug. The guards compared a path.resolve()-normalized path against the raw working-directory string, so a trailing-slash or relative install dir (e.g. --install-dir=my-app/) rejected every env write — including plain .env — with no fallback, since set_env_values is the only sanctioned env channel. Init then failed and the orchestrator correctly aborted.

The fix canonicalizes the root before comparing (inresolveEnvPath and the rm gate) and normalizes installDir once at both runner entry points.

@edwinyjlim
edwinyjlim requested a review from a team as a code owner September 16, 2026 18:43
@github-actions

Copy link
Copy Markdown

🧙 Wizard CI

Run the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands:

Test all apps:

  • /wizard-ci all

Test all apps in a directory:

  • /wizard-ci ai-observability
  • /wizard-ci basic-integration
  • /wizard-ci mcp-analytics
  • /wizard-ci replay-vision
  • /wizard-ci revenue
  • /wizard-ci self-driving
  • /wizard-ci warehouse
  • /wizard-ci warehouse-seeded

Test an individual app:

  • /wizard-ci ai-observability/anthropic
  • /wizard-ci ai-observability/google-adk
  • /wizard-ci ai-observability/groq
Show more apps
  • /wizard-ci ai-observability/manual-capture
  • /wizard-ci ai-observability/openai
  • /wizard-ci ai-observability/openai-agents
  • /wizard-ci ai-observability/opentelemetry
  • /wizard-ci ai-observability/vercel-ai
  • /wizard-ci basic-integration/android
  • /wizard-ci basic-integration/angular
  • /wizard-ci basic-integration/astro
  • /wizard-ci basic-integration/django
  • /wizard-ci basic-integration/fastapi
  • /wizard-ci basic-integration/flask
  • /wizard-ci basic-integration/flutter
  • /wizard-ci basic-integration/javascript-node
  • /wizard-ci basic-integration/javascript-web
  • /wizard-ci basic-integration/laravel
  • /wizard-ci basic-integration/next-js
  • /wizard-ci basic-integration/nuxt
  • /wizard-ci basic-integration/python
  • /wizard-ci basic-integration/rails
  • /wizard-ci basic-integration/react-native
  • /wizard-ci basic-integration/react-router
  • /wizard-ci basic-integration/sveltekit
  • /wizard-ci basic-integration/swift
  • /wizard-ci basic-integration/tanstack-router
  • /wizard-ci basic-integration/tanstack-start
  • /wizard-ci basic-integration/vue
  • /wizard-ci mcp-analytics/custom-dispatcher
  • /wizard-ci mcp-analytics/typescript-sdk
  • /wizard-ci replay-vision/javascript-node
  • /wizard-ci replay-vision/next-js
  • /wizard-ci replay-vision/react-vite
  • /wizard-ci revenue/stripe
  • /wizard-ci self-driving/astro
  • /wizard-ci self-driving/fastapi
  • /wizard-ci self-driving/nuxt
  • /wizard-ci self-driving/react-router
  • /wizard-ci self-driving/sveltekit
  • /wizard-ci warehouse/monorepo-env
  • /wizard-ci warehouse/multi-source-next
  • /wizard-ci warehouse/stripe-node
  • /wizard-ci warehouse/zero-source
  • /wizard-ci warehouse-seeded/next-stripe
  • /wizard-ci warehouse-seeded/next-stripe-declined

Test against a Context Mill branch:

  • /wizard-ci all context-mill:my-branch

Add context-mill:<branch> to any command above to pin the Context Mill branch. It defaults to main.

Results will be posted here when complete.

@johncwaters

Copy link
Copy Markdown
Contributor

Merge conflicts op :(

@johncwaters johncwaters left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Automated review. Not written by a human.

Reviewed the path normalization fix. Root and target are both canonicalized before every prefix check, traversal attempts are still rejected, and the new tests cover trailing-slash, relative and escaping inputs. No issues found.

@gewenyu99
gewenyu99 enabled auto-merge (squash) October 7, 2026 14:01
@gewenyu99
gewenyu99 merged commit e941407 into main Oct 7, 2026
18 checks passed
@gewenyu99
gewenyu99 deleted the env-file-blocked branch October 7, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants