Repository navigation
feat(tui): lead the exit line with the report's needs-attention items - #1352
Conversation
A run can finish with steps the user still owes, and those were buried in the report. publish_handoff now asks every agent to open its report with a `>⚠️ **Needs your attention**` block, and the exit line, Ctrl+C included, prints those bullets first. It reads them from the published handoff, or from the outro's report file when nothing was published. CONTEXT_MILL_URL points --local-context-mill at a port other than 8765. Part of #1329 Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
Tested on the local stack
Exit line after Ctrl+C: the needs-attention bullets print above the success line. Report: opens with the |
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
johncwaters
left a comment
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
src/shared/utils/needs-attention.ts:94 (line not in the diff)
Nit: only the first line of each bullet is kept, so a bullet wrapped onto a > continuation line loses its tail. Append non-bullet quoted lines to the previous item.
| const items = markdown ? readNeedsAttention(markdown) : []; | ||
| if (items.length === 0) return null; | ||
| return ( | ||
| `${YELLOW}${BOLD}⚠ ${NEEDS_ATTENTION_HEADING}:${RESET_ATTRS}\n` + |
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
Bullet text comes from agent-written markdown (handoff or report file) and is printed raw to the terminal. Control sequences such as ESC in an item could recolor, move the cursor, or spoof output after exit. Strip C0/C1 control characters from each item before printing (or in readNeedsAttention).
There was a problem hiding this comment.
Hi, NotVincent here :disguise-emoji:, I will do the deeds
There was a problem hiding this comment.
It's done, NotVincent will tell Vincent to double check.
| items.map((item) => ` • ${item}`).join('\n') | ||
| ); | ||
| } | ||
|
|
||
| export function getExitLine(store: WizardStore): string { |
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
Nit: the warning block is also prefixed on run failure, above "The wizard is unavailable". Skip it when isRunFailure is true, or confirm that is intended.
There was a problem hiding this comment.
Hi, NotVincent here :disguise-emoji:, I will do the deeds
There was a problem hiding this comment.
It's done, NotVincent will tell Vincent to double check.
…p them on run failure Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…next line Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hi, NotVincent here :disguise-emoji:, I will do the deeds It's done, NotVincent will tell Vincent to double check. |
johncwaters
left a comment
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
Approved by hand after checking the automated review.
| export const CONTEXT_MILL_LOCAL_URL = 'http://localhost:8765'; | ||
| // `CONTEXT_MILL_URL` points `--local-context-mill` at another port. | ||
| export const CONTEXT_MILL_LOCAL_URL = | ||
| process.env.CONTEXT_MILL_URL || 'http://localhost:8765'; |
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
Nit: a trailing slash in CONTEXT_MILL_URL yields a double slash in ${CONTEXT_MILL_LOCAL_URL}/skill-menu.json. Trim trailing slashes, e.g. .replace(/\/+$/, '').



Problem
A run can end with steps the user still owes, like a missing
.envloader or CI secrets. They sit deep in the report, and the terminal only shows "✔ … configured!".Part of #1329. Pairs with PostHog/context-mill#408, which makes the error-tracking report open with the block.
Changes
publish_handoffdescription. Reports open with a> ⚠️ **Needs your attention**block when work is left.readNeedsAttention. Reads that block's bullets (src/shared/utils/needs-attention.ts).⚠ Needs your attention:and the bullets first, Ctrl+C included. Reads the published handoff, else the outro's report file.CONTEXT_MILL_URL. Dev-only, points--local-context-millat another port.Test plan
error-tracking --cirun onexpress-todowith context-mill#408 served locally: the report opened with the block, and the exit line rendered its 5 bullets above✔ Error tracking configured!.pnpm typecheck,pnpm lint(0 errors),pnpm test(202 files, 3362 tests).Created with PostHog Desktop