Repository navigation
Conversation
safeReadFile already skips files that fail with these codes. Log them to the debug file and do not send them to error tracking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 1ca4d362-2cc1-4ac4-be14-31f7343e400e
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
gewenyu99
approved these changes
Oct 12, 2026
gewenyu99
marked this pull request as ready for review
October 12, 2026 13:37
gewenyu99
deleted the
posthog-self-driving/fixbounded-fs-treat-windows-unknown-1de43e
branch
October 12, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fs.readFileSynccan fail withUNKNOWN(libuv cannot map the OS error, for example on a locked or cloud-placeholder file) or withEBUSY.safeReadFilecatches the error and skips the file, so users see no failure. ButreportFsErrorsends every code that is not inBENIGN_FS_ERROR_CODESto error tracking.check_env_keys.envscan makes noise in error tracking. The noise is split across many issues because the stack traces are different, and the team spends triage time on it.Origin
820e2e5Changes
UNKNOWNandEBUSYtoBENIGN_FS_ERROR_CODES. These errors now go only to the debug log. The walk still skips the file.Note
All bounded-fs walk and read steps share this set. A real
UNKNOWNfrom another cause is also only logged.ETIMEDOUTto the same set at the oldsrc/utils/path. The two changes do not conflict in intent, but fix(detection): treat ETIMEDOUT as a benign fs error #1116 needs a rebase ontosrc/shared/utils/.Test plan
vitest run src/shared/utils/__tests__/bounded-fs-walk.test.ts: new cases check thatsafeReadFilereturnsnullforUNKNOWNandEBUSY, logs once, and does not capture an exception.pnpm typecheckeslintandprettier --checkon the changed filespnpm testnot run locally; covered by CI.Agent context
ETIMEDOUTfrom fix(detection): treat ETIMEDOUT as a benign fs error #1116, to keep this change to the reported symptom.Created with PostHog Desktop from this inbox report.
🤖 Generated with Claude Code