Repository navigation
[Experimental] Model state native output - #1634
Jerry-Jinfeng-Guo wants to merge 27 commits into
Quality Gate passed
Annotations
sonarqubecloud / SonarCloud Code Analysis
This lambda has 35 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4qdvdWhUKH3B8EY&open=AaEsU4qdvdWhUKH3B8EY&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4yjvdWhUKH3B8Eh&open=AaEsU4yjvdWhUKH3B8Eh&pullRequest=1634
Check warning on line 257 in tests/unit/test_power_grid_model.py
sonarqubecloud / SonarCloud Code Analysis
Refactor this exception test to have only one invocation possibly throwing an exception.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4i3vdWhUKH3B8EM&open=AaEsU4i3vdWhUKH3B8EM&pullRequest=1634
Check warning on line 499 in power_grid_model_c/power_grid_model_c/src/model.cpp
sonarqubecloud / SonarCloud Code Analysis
This lambda has 38 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4nOvdWhUKH3B8EQ&open=AaEsU4nOvdWhUKH3B8EQ&pullRequest=1634
Check warning on line 432 in power_grid_model_c/power_grid_model_c/src/model.cpp
sonarqubecloud / SonarCloud Code Analysis
This function has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4nOvdWhUKH3B8EO&open=AaEsU4nOvdWhUKH3B8EO&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Use has_value() or another member function to clarify that the code tests the presence of a value in the "optional", not the contained "signed char" value itself.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4yjvdWhUKH3B8Ei&open=AaEsU4yjvdWhUKH3B8Ei&pullRequest=1634
Check warning on line 180 in tests/unit/test_power_grid_model.py
sonarqubecloud / SonarCloud Code Analysis
Unify assertion argument order in this file; both "actual first" and "expected first" conventions are used.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4i3vdWhUKH3B8EN&open=AaEsU4i3vdWhUKH3B8EN&pullRequest=1634
Check warning on line 515 in power_grid_model_c/power_grid_model_c/src/model.cpp
sonarqubecloud / SonarCloud Code Analysis
Use "std::byte" for byte-oriented memory access.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4nOvdWhUKH3B8ER&open=AaEsU4nOvdWhUKH3B8ER&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
This function should be declared "const".
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4uwvdWhUKH3B8Eg&open=AaEsU4uwvdWhUKH3B8Eg&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this method is empty, or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4uwvdWhUKH3B8Ef&open=AaEsU4uwvdWhUKH3B8Ef&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 31 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4qdvdWhUKH3B8EU&open=AaEsU4qdvdWhUKH3B8EU&pullRequest=1634
Check failure on line 599 in power_grid_model_c/power_grid_model_c/src/model.cpp
sonarqubecloud / SonarCloud Code Analysis
Rewrite the code so that you no longer need this "delete".
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4nOvdWhUKH3B8ES&open=AaEsU4nOvdWhUKH3B8ES&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Use has_value() or another member function to clarify that the code tests the presence of a value in the "optional", not the contained "signed char" value itself.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4yjvdWhUKH3B8Ek&open=AaEsU4yjvdWhUKH3B8Ek&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Use has_value() or another member function to clarify that the code tests the presence of a value in the "optional", not the contained "signed char" value itself.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4yjvdWhUKH3B8Ej&open=AaEsU4yjvdWhUKH3B8Ej&pullRequest=1634
Check warning on line 438 in power_grid_model_c/power_grid_model_c/src/model.cpp
sonarqubecloud / SonarCloud Code Analysis
This lambda has 27 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4nOvdWhUKH3B8EP&open=AaEsU4nOvdWhUKH3B8EP&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Replace the redundant type with "auto".
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4qdvdWhUKH3B8EZ&open=AaEsU4qdvdWhUKH3B8EZ&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
This function has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4uivdWhUKH3B8Ee&open=AaEsU4uivdWhUKH3B8Ee&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4r8vdWhUKH3B8Ec&open=AaEsU4r8vdWhUKH3B8Ec&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Use has_value() or another member function to clarify that the code tests the presence of a value in the "optional", not the contained "signed char" value itself.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4yjvdWhUKH3B8El&open=AaEsU4yjvdWhUKH3B8El&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
This function has 9 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4uivdWhUKH3B8Ed&open=AaEsU4uivdWhUKH3B8Ed&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Replace this use of "push_back" with "emplace_back".
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU40CvdWhUKH3B8En&open=AaEsU40CvdWhUKH3B8En&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4qdvdWhUKH3B8EX&open=AaEsU4qdvdWhUKH3B8EX&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4qdvdWhUKH3B8EV&open=AaEsU4qdvdWhUKH3B8EV&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Use the init-statement to declare "n_scenarios" inside the if statement.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4y0vdWhUKH3B8Em&open=AaEsU4y0vdWhUKH3B8Em&pullRequest=1634
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AaEsU4qdvdWhUKH3B8Ea&open=AaEsU4qdvdWhUKH3B8Ea&pullRequest=1634