Skip to content

Feature/separate python error types - #546

Merged
Jerry-Jinfeng-Guo merged 6 commits into
mainfrom
feature/separate-python-error-types
Mar 26, 2024
Merged

Jerry-Jinfeng-Guo merged 6 commits into
mainfrom
feature/separate-python-error-types

Conversation

@mgovers

@mgovers mgovers commented Mar 26, 2024

Copy link
Copy Markdown
Member

Part 1 of #509 : public interface

mgovers added 3 commits March 22, 2024 13:18
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the feature New feature or request label Mar 26, 2024
@mgovers mgovers self-assigned this Mar 26, 2024
Comment thread tests/unit/test_error_handling.py Resolved
Comment thread tests/unit/test_error_handling.py Resolved
Comment thread tests/unit/test_error_handling.py Resolved
mgovers added 2 commits March 26, 2024 10:16
…on-error-types

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hereby approve. Let's leave the skipped tests up to the team to decide whether we remove them all together or spend some effort crafting a couple cases.

@sonarqubecloud

Copy link
Copy Markdown

@Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 96a81b0 Mar 26, 2024
@Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo deleted the feature/separate-python-error-types branch March 26, 2024 17:06
@mgovers mgovers mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants