Add GitHub App "Review Me" to DSC Resource Kit repositories #430

Activity

1. Johan Ljunggren (johlju)

   changed the title [-]Add GitHUb App "Reveiew Me" to DSC Resource Kit repositories[/-] [+]Add GitHub App "Reveiew Me" to DSC Resource Kit repositories[/+] on Aug 7, 2018
2. Johan Ljunggren (johlju)

   added

   enhancementThe issue is an enhancement request.The issue is an enhancement request.

   help wantedThe issue is up for grabs for anyone in the community.The issue is up for grabs for anyone in the community.

   in progressThe issue is being actively worked on by someone.The issue is being actively worked on by someone.

   and removed

   help wantedThe issue is up for grabs for anyone in the community.The issue is up for grabs for anyone in the community.

   on Aug 7, 2018
3. johlju commented on Aug 7, 2018

   

   Johan Ljunggren (johlju)

   on Aug 7, 2018

   ContributorAuthor

   More actions

   First out is the repository DscResource.Tests, to test the functionality in real scenarios.
4. Johan Ljunggren (johlju)

   changed the title [-]Add GitHub App "Reveiew Me" to DSC Resource Kit repositories[/-] [+]Add GitHub App "Review Me" to DSC Resource Kit repositories[/+] on Aug 7, 2018
5. johlju commented on Aug 7, 2018

   

   Johan Ljunggren (johlju)

   on Aug 7, 2018

   ContributorAuthor

   More actions

   Problems using Review Me (after real scenario tests):

   • Does not detect merge conflicts (Support "This branch has conflicts that must be resolved" z0al/probot-review-me#3)
   • Does not remove 'waiting...' labels (issue Support optionally removing existing labels when setting z0al/probot-review-me#2)
   • Does not support 'waiting for CLA pass' (issue Support more labels with different statuses z0al/probot-review-me#1)
   • Updates review label on all PR's on merge of, or push to, any one PR (issue Sets the review label on other event than a push event z0al/probot-review-me#4)

   Where the last one is the most serious one for our current workflow. It will set 'needs review' on every PR that has a 'waiting label'. I think we need to look at changing our workflow, or how the labels are used.
6. johlju commented on Aug 10, 2018

   

   Johan Ljunggren (johlju)

   on Aug 10, 2018

   ContributorAuthor

   More actions

   Uninstalled Review Me from DscResource.Tests for the time being due to the problems above. I have not remove the configuration file yet, I keep this issue open to see if we can get any improvements to the app, or a reminder to remove the configuration file before closing this issue.
7. Johan Ljunggren (johlju)

   added

   externalThe issue cannot be resolved within the DSC Resource Kit.The issue cannot be resolved within the DSC Resource Kit.

   on holdThe issue or pull request has been put on hold by a maintainer.The issue or pull request has been put on hold by a maintainer.

   and removed

   in progressThe issue is being actively worked on by someone.The issue is being actively worked on by someone.

   externalThe issue cannot be resolved within the DSC Resource Kit.The issue cannot be resolved within the DSC Resource Kit.

   on Aug 10, 2018