Skip to content
This repository was archived by the owner on Feb 24, 2021. It is now read-only.

Adds Office365DSC References into the DSCResources Kit - #500

Closed
Nik Charlebois (NikCharlebois) wants to merge 2 commits into
PowerShell:masterfrom
NikCharlebois:master
Closed

Nik Charlebois (NikCharlebois) wants to merge 2 commits into
PowerShell:masterfrom
NikCharlebois:master

Conversation

@NikCharlebois

@NikCharlebois Nik Charlebois (NikCharlebois) commented Apr 16, 2019 •

Copy link
Copy Markdown
Contributor

Pull Request (PR) description

Adds Office365DSC References into the DSCResources Kit

This Pull Request (PR) fixes the following issues

N/A

Task list

  • This PR changes documentation

This change is Reviewable

14 of 18 tasks

@johlju Johan Ljunggren (johlju) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nik Charlebois (@NikCharlebois))


.gitmodules, line 196 at r1 (raw file):

[submodule "DscResources/Office365Dsc"]

I think this would have been added, and the correct reference in the DscResource folder if the submodule was added using git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame> (see issue template).
DId you run the git submodule command?

@gaelcolas

Copy link
Copy Markdown
Contributor

I think change is in motion and next community call will be the time to reconsider this.

@gaelcolas gaelcolas (gaelcolas) added new module submission A request that the community evaluate a resource module for submission into the DSC Resource Kit. on hold The issue or pull request has been put on hold by a maintainer. labels Jun 25, 2019
@gaelcolas

Copy link
Copy Markdown
Contributor

As announced during the last community call, we'd love to have this as part of dsccommunity when we start the transfer.
I'll get in touch with you Nik Charlebois (@NikCharlebois) in the next few weeks to discuss this.

@gaelcolas

Copy link
Copy Markdown
Contributor

I'm closing this one as we'll probably transfer and archive this repository.
Nik Charlebois (@NikCharlebois) let me know if you want a particular listing in DSC Community.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new module submission A request that the community evaluate a resource module for submission into the DSC Resource Kit. on hold The issue or pull request has been put on hold by a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants