Skip to content

bubble up warning if a user isn't compatible with upcoming v2 #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscarlevin merged 2 commits into from
Jul 28, 2023
Merged

bubble up warning if a user isn't compatible with upcoming v2 #505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf4689c
bubble up warning if a user isn't compatible with upcoming v2
StevenClontz Jul 28, 2023
0abcc6d
add success messages, error report to support
oscarlevin Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions pretext/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
CORE_COMMIT,
)
from .project import Project
from .project.refactor import Project as ProjectRefactor


log = logging.getLogger("ptxlogger")
Expand Down Expand Up @@ -77,6 +78,27 @@ def main(ctx: click.Context, targets: bool) -> None:
`pretext build --help`.
"""
if (pp := utils.project_path()) is not None:
try:
ProjectRefactor.parse(pp)
log.info(
"------------------------------------\n Good news: \n Your project.ptx file is ready for\n the 2.0.0 release of PreTeXt-CLI.\n------------------------------------\n"
)
except Exception as e:
log.warning(
"Your project.ptx or publication file may not be compatible with the "
+ "upcoming 2.0.0 release of PreTeXt-CLI."
)
log.warning(
"For more information or to help us fix a possible bug, please visit"
)
log.warning(" https://groups.google.com/g/pretext-support/c/bwf51qOoT9c")
log.warning(
"and share the result of running `pretext support` on your machine with us."
)
log.info("")
log.warning(f"Exception info: {e}")
log.info("")
log.warning("Continuing with current version...")
if targets:
Project().print_target_names()
return
Expand Down Expand Up @@ -142,8 +164,22 @@ def support() -> None:
log.info("------------------------")
log.info(utils.project_xml_string())
log.info("------------------------")
try:
ProjectRefactor.parse()
log.info(
"Your project.ptx file will be compatible with the upcoming 2.0.0 release of PreTeXt-CLI."
)
except Exception as e:
log.warning(
"Your project.ptx or publication file may not be compatible with the "
+ "upcoming 2.0.0 release of PreTeXt-CLI."
)
log.info("")
log.warning(f"Exception info: {e}")
log.info("")
project = Project()
project.init_ptxcore()
log.info("------------------------")
for exec_name in project.executables():
if utils.check_executable(exec_name) is None:
log.warning(
Expand Down