Skip to content

reconfigure playwright install process #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscarlevin merged 1 commit into from
Aug 5, 2023
Merged

reconfigure playwright install process #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pretext/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def interactive(
)
except Exception as e:
log.error(
"Failed to generate interactive element previews. Check debug log for info."
"Failed to generate interactive element previews. You might need to run `playwright install-deps` to get this to work. Check debug log for info."
)
log.debug(e)
log.debug("Exception info:\n##################\n", exc_info=True)
Expand Down
6 changes: 3 additions & 3 deletions pretext/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,9 @@ def playwright_install() -> None:
Run `playwright install` to ensure that its required browsers and tools are available to it.
"""
try:
log.info("Attempting to install/update required playwright packages.")
subprocess.run("playwright install-deps", shell=True)
subprocess.run("playwright install", shell=True)
log.info("Checking for update for required playwright chromium browser.")
# subprocess.run("playwright install-deps", shell=True)
subprocess.run("playwright install chromium", shell=True)
log.debug("Installed dependencies to capture interactive previews")
except Exception as e:
log.critical(
Expand Down