Fix exception-by-pointer leak; add missing test coverage - #32
Merged
dmccoystephenson merged 1 commit intoAug 3, 2026
Merged
Conversation
Grid::getLocationByCoordinates, Grid::getLocation, Environment::getFirstEntity, and Environment::getEntity threw new std::runtime_error(...) (heap pointer), leaking the exception object on every "not found" path. Now throw by value and catch by const reference at the one catch site in Environment::moveEntityInDirection. Also adds direct test coverage for several previously-untested public methods: Environment::setName/printInfo/addEntityToLocation, Grid::setSize/addLocation/ getLocationByCoordinates, and Location::getEntities/getNumEntities. Grid::removeLocation is deliberately left without a new test: writing one surfaced a pre-existing iterator-invalidation bug (reliable UB, not a clean assertion failure), filed separately as #31. Closes #29 Closes #28 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric:
Repo-specific:
Summary: one item is a deliberate partial per the "characterization, not change" rule — This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). |
dmccoystephenson
deleted the
feature/fix-exception-leak-and-test-coverage
branch
August 3, 2026 09:41
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #29
Closes #28
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).