Skip to content

test(coding-agent): remove unused legacy harness - #498

Merged
snimu merged 1 commit into
mainfrom
chore/remove-legacy-test-harness
Jul 22, 2026
Merged

snimu merged 1 commit into
mainfrom
chore/remove-legacy-test-harness

Conversation

@snimu

@snimu snimu commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Why

test/test-harness.ts was the predecessor to the deterministic test/suite/harness.ts integration layer. Nothing in the product test suite imports it anymore; its only consumer was a 321-line test file that tested the obsolete harness itself.

What changes

  • removes the unused 446-line legacy harness
  • removes its self-tests
  • updates the suite guidance to extend the current harness when integration coverage needs a missing capability

Coverage

No product behavior assertions are removed: the deleted harness had no product-test consumers. The current suite harness is exercised across the coding-agent integration suite.

  • npm run check
  • test/suite/agent-session-prompt.test.ts: 29 passed in 72 ms

Net test/code reduction: 767 lines.


Note

Low Risk
Test-only cleanup with no remaining imports of the removed harness; no product behavior changes.

Overview
Removes the obsolete test/test-harness.ts integration layer (~446 lines) and its dedicated test-harness.test.ts self-tests (~321 lines). Product tests already use test/suite/harness.ts and the shared faux provider; nothing else imported the legacy path.

test/suite/README.md now tells contributors to extend test/suite/harness.ts when deterministic integration tests need a capability, instead of avoiding or extending the removed legacy harness.

Reviewed by Cursor Bugbot for commit 5683301. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove unused legacy test harness from coding-agent

Deletes test-harness.ts and its companion test-harness.test.ts, which implemented a faux provider and session factory for integration tests. The README.md is updated to direct contributors to extend the current harness at test/suite/harness.ts instead.

Macroscope summarized 5683301.

@snimu
snimu merged commit 5292a74 into main Jul 22, 2026
11 checks passed
@kevinjosethomas
kevinjosethomas deleted the chore/remove-legacy-test-harness branch July 24, 2026 20:00
zhengr pushed a commit to zhengr/prime-agent that referenced this pull request Aug 8, 2026
When OAuth refresh fails during model discovery, getApiKey() now returns
undefined instead of throwing. This allows the app to start and fall back
to other providers, so the user can /login to re-authenticate.

fixes PrimeIntellect-ai#498
zhengr pushed a commit to zhengr/prime-agent that referenced this pull request Aug 8, 2026
When OAuth refresh fails during model discovery, getApiKey() now returns
undefined instead of throwing. This allows the app to start and fall back
to other providers, so the user can /login to re-authenticate.

fixes PrimeIntellect-ai#498

feat(coding-agent): support searching/resuming sessions by ID

- Session picker (pi -r) now searches session IDs in addition to message content
- --session flag accepts UUID prefix (e.g., pi --session a8ec1c2a)
- Documented in README.md

fixes PrimeIntellect-ai#495
zhengr pushed a commit to zhengr/prime-agent that referenced this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants