Add False - #2802
Merged
Merged
Add False#2802
Conversation
RunDevelopment
requested changes
Mar 13, 2021
RunDevelopment
left a comment
RunDevelopment
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR @edukisto!
2 minor nits and then it's gtg.
|
|
||
| ---------------------------------------------------- | ||
|
|
||
| [ |
Member
There was a problem hiding this comment.
This isn't a nit but a tip for the future:
This JSON looks like you formatted it yourself. With the command npm run test:languages -- --accept, the test suite will automatically insert the formatted actual token stream for you.
Contributor
Author
There was a problem hiding this comment.
Ah, I unreasonably forgot about --accept. I’ve never used the feature, because I write tests before I write regexes. I should and I will use it for “post-processing”.
Contributor
Author
There was a problem hiding this comment.
Thank you for reminding!
RunDevelopment
approved these changes
Mar 13, 2021
Member
|
Thank you for contributing! |
Contributor
Author
|
Thank you, @RunDevelopment! |
This was referenced Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2801.