[aristath]

Context

This PR contains various tweaks and improvements:

• Removes the grunt task. Our CSS & JS files are so small and basic that we don't need build processes, minification etc.
• Fixes errors in VSCode due to PHPCompatibility checks (tweaked the PHPCS ruleset)
• Code readability tweaks, especially in places where we print HTML in admin pages. The structure didn't change there, just separating long lines etc.
• Made a few strings translatable
• Fixed a bug where a variable was undefined
• Changed the enqueue functions to point to the correct JS & CSS files
• Replaced the yst prefix with epch (Emilia Projects Comment Hacks)
• Removed the Composer autoloader and added a new custom one with a hardcoded classmap

Relevant technical choices:

Test instructions

• Activate the plugin - ensure there are no fatalities in the autoloader
• Go the the admin page - check that the page appears correctly and tabs work as expected

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Block/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

• I have written documentation for this change.

Quality assurance

• I have tested this code to the best of my abilities.
• I have added unit tests to verify the code works as intended.
• I have checked that the base branch is correctly set.

Fixes #

[aristath]

$roles was undefined here. The doc for this filter was saying "Defaults to contributor and up", so the array used here contains these roles.

[jdevalk]

Couple of remarks above.

I also think we should update composer.json to be all Emilia not joost.blog?

[jdevalk]

Few more comments.

[aristath]

I also think we should update composer.json to be all Emilia not joost.blog?

I changed the homepage to point to https://emilia.capital. The authors array however has your name and personal blog, I don't think we have to change that, should be fine to keep it since it describes the author 🤔

[github-actions]

WordPress Playground

You can easily test this pull request on the WordPress Playground.