Repository navigation
Run browser tests only in Playwright - #106
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 seconds. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![project516-review-bot[bot]](https://avatars.githubusercontent.com/in/4903871?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR migrates browser testing from mocha-headless-chrome to Playwright. It removes the old tests job (which ran mocha-headless-chrome with puppeteer), makes tests-browsers (Playwright matrix across chromium/firefox/webkit × isolated/plain) the required gate by removing continue-on-error, and adds a new lightweight tests job that depends on tests-browsers and fails if any matrix leg failed. The mocha-headless-chrome scripts, dependencies (mocha-headless-chrome, puppeteer-core, start-server-and-test, npm-run-all), and the helper script scripts/dump-test-page.mjs are removed. CI evidence shows 200/200 tests-browsers jobs passed over 34 runs.
review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve
There was a problem hiding this comment.
The PR replaces Mocha-headless-Chrome browser tests with Playwright-based tests for Chromium, Firefox, and WebKit in isolated/plain modes, plus a separate JSPi mode job. It updates the CI workflow to make Playwright tests the gate, removes related dependencies and scripts, and updates documentation. The change includes retry logic for Playwright installation to handle flaky apt mirrors.
review-bot, model nvidia/nemotron-3-super-120b-a12b:free, verdict approve
There was a problem hiding this comment.
The PR replaces the mocha-headless-chrome browser tests with Playwright, making the Playwright tests the gate. It removes the old test job and dependencies, adds a new checker job that depends on the Playwright tests, and updates documentation. The changes include removing mocha-headless-chrome, puppeteer-core, and related scripts, adding retry logic for browser and native FFmpeg installs, and updating AGENTS.md to reflect the new test command.
review-bot, model nvidia/nemotron-3-super-120b-a12b:free, verdict approve
|
@coderabbitai review |
|
1 participant
Removes the mocha-headless-chrome
testsjob and makestests-browsers(Playwright, chromium/firefox/webkit, isolated/plain) the gate.testsis now a small job that needstests-browsersand fails unless it succeeded, so the required check name stays.tests-browsersno longer hascontinue-on-error.scripts/dump-test-page.mjs, the mocha-headless-chrome scripts (test,test:all,test:browser:*except playwright,pretest) and the unused devDependenciesmocha-headless-chrome,puppeteer-core,start-server-and-test,npm-run-all, plus the puppeteer entry inpnpm-workspace.yaml. Lockfile updated.pnpm run test:browser:playwright <browser> <mode>.Evidence: 200 of 200
tests-browsersjobs passed over 34 CI runs from 2026-10-06 to 2026-10-07, 27 cancelled by superseding pushes, 0 failures. No changelog entry, since this is CI and dev tooling only.