Repository navigation
Conversation
The lrclib integration (1a8b0e6) fetches lyrics for every track by default. When the lookup rejects or returns invalid lyrics, fullscreen player components call autoHideSyncLyrics(), which unconditionally reset fullscreenPlayer.mode — including PLAY_QUEUE, collapsing the 'Now playing' split view to a bare cover square on every track without lrclib lyrics. Guard autoHideSyncLyrics to act only in SYNC_LYRICS mode. The auto-hide/restore flow for lyrics is preserved; the play queue is no longer affected. Co-Authored-By: Claude Code <noreply@anthropic.com>
Member
|
Этот фикс отходит от оригинальной задумки в приложении. Мы сделаем его чуть иначе позже |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Где воспроизводится
Полноэкранный плеер основного окна (открывается кликом по обложке в баре плеера внизу), режим с очередью воспроизведения — сплит «обложка + очередь».
Проблема
Интеграция lrclib запрашивает текст для каждого трека. Если запрос отклоняется или возвращает невалидный текст, компоненты полноэкранного плеера вызывают
autoHideSyncLyrics(), который безусловно сбрасывалfullscreenPlayer.mode— включаяPLAY_QUEUE.Шаги:
Что сделано
autoHideSyncLyricsдействует только в режимеSYNC_LYRICS: авто-скрытие/восстановление текста сохранено, режим очереди больше не сбрасывается.Проверено
macOS 26.6 (arm64), клиент 5.119.0, мод 1.33.10: треки с текстом и без — очередь остаётся открытой, скрытие текста работает как раньше.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.