Repository navigation
Fix GATT Notifications #119
Description
GATTServer should not be sending GATT notifications to the connected client that wrote the value.
- If the Peripheral wrote a new value, all connected clients should be notified.
- If a Central wrote a value, all connected centrals, except the one that wrote the value, should be notified.
Activity
colemancda commentedon Jan 20, 2019
Initial work in ab33985 . Need to differentiate between:
colemancda commentedon Jan 21, 2019
Notifications for characteristics will not work for multiple characteristics with the same UUID in a service.
Bluetooth/Sources/GATTServer.swift
Line 280 in ab33985
#119 Fixed GATT notifications
Fixed GATT Notifications
colemancda commentedon Jan 21, 2019
There seems to also be issues in the
GATTClientimplementation https://gist.github.com/wlisac/75650c0bc54ffb4a248b8aff306ff715sbrewin commentedon Sep 1, 2020
I can confirm the there is an issue around GATTClient processing notifications. A peripheral receives and processes the subscribe request from the GATTClient and the unsubscribe request when the GATTClient is closed. Notifications sent by the peripheral are not being processed correctly by the GATTClient.
Before I debug further I thought I’d ask if anyone else is actively working on this and if so what progress has been made?
justinmiller62 commentedon Apr 27, 2021
I am also getting this error
Assertion failed: Invalid range: file /data/scanner/SwiftScanner/.build/checkouts/Bluetooth/Sources/BluetoothGATT/GATTClient.swift, line 470Whenever I start a notify on characteristic. It doesn't happen every time but does once about 1 in 3 times.
Fixed GATT Notifications
Fixed GATT Notifications