Add support for Foundation.SortDescriptor - #33
Merged
Conversation
… FetchRequest.SortDescriptor
Code Coverage OverviewLanguages: Swift Swift / code-coverage/llvm-covThe overall coverage in commit 635e2a0 in the Show a code coverage summary of the most impacted files.
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #14
Rounds out
Foundation.SortDescriptorsupport with full bidirectional conversions, plus cross-platformSortComparator/SortOrdersupport via swift-foundation'sFoundationEssentials:FetchRequest.SortDescriptorconforms toSortComparator(comparingModelData), with anorder: SortOrderproperty andorder-based initializers — available on all platforms with Foundation, not just Darwin.FetchRequest.SortDescriptor.toFoundation(comparing:)converts back toFoundation.SortDescriptor, returningnilfor function-based sort terms, which have no Foundation equivalent.NSSortDescriptorround-trip:init?(_:)(nil when the sort descriptor has no key path) andtoFoundation().FetchRequestconvenience initializer accepting[Foundation.SortDescriptor<Root>].CoreDataModelfetch request bridging now reuses the sharedtoFoundation()conversion.SortComparatorsorting, the nil cases, and the new initializers.