Skip to content

2.0 wishlist #259

Description

@davidhewitt

Just some tidy-ups I'd like to do whenever we get around to a next breaking release:

  • Change Optional[Sequence[str]] arguments to RustExtension to just be Sequence[str] = ().
  • Remove deprecated options to RustExtension.
  • Remove Binding.Exec (just use RustBin).
  • Require all arguments to RustExtension except for target to be passed as keywords (i.e. after * separator).
  • Remove build_rust subcommand (the setup.py entry point is deprecated, so no need to support it IMO)
  • Remove version.py (just set the corresponding values in __init__.py)

Activity

  1. jameshilliard commented on Oct 3, 2022

    @jameshilliard
    Contributor
    • Remove build_rust subcommand (the setup.py entry point is deprecated, so no need to support it IMO)

    I would recommend holding off on this as it's not currently possible to migrate setuptools setup.py package build infrastructure to pep517 package build infrastructure due to setuptools pep517 support effectively requiring setup.py build infrastructure itself for bootstrapping.

    Currently setup.py builds are still supported in the latest setuptools release, IMO we should probably support them here until we start requiring a version of setuptools that no longer supports setup.py style builds.

  2. davidhewitt commented on Oct 4, 2022

    @davidhewitt
    MemberAuthor

    Thanks for the heads up! I'm in no rush to push forward with a 2.0 release, so potentially we can just wait for upstream before we consider a 2.0 in that case.

  3. jameshilliard commented on Oct 4, 2024

    @jameshilliard
    Contributor
    • Remove Binding.Exec (just use RustBin).

    I think for embedding binaries in site-packages like in selenium we still may need to keep Binding.Exec as RustBin is only for stuff that goes in the scripts path AFAIU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions