Skip to content

Setuptools deprecation warning with setuptools-rust #313

Open
Open
Setuptools deprecation warning with setuptools-rust#313

Description

@reaperhulk
reaperhulk
opened on Feb 12, 2023

In cryptography builds we have been getting this deprecation warning for a while:

setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'cryptography.hazmat.bindings._rust' as data is deprecated, please list it in `packages`.
      ############################
      # Package would be ignored #
      ############################
      Python recognizes 'cryptography.hazmat.bindings._rust' as an importable package,
      but it is not listed in the `packages` configuration of setuptools.

      'cryptography.hazmat.bindings._rust' has been automatically added to the distribution only
      because it may contain data files, but this behavior is likely to change
      in future versions of setuptools (and therefore is considered deprecated).

      Please make sure that 'cryptography.hazmat.bindings._rust' is included as a package by using
      the `packages` configuration field or the proper discovery methods
      (for example by using `find_namespace_packages(...)`/`find_namespace:`
      instead of `find_packages(...)`/`find:`).

      You can read more about "package discovery" and "data files" on setuptools
      documentation page.

We declare cryptography.hazmat.bindings._rust as the target in our RustExtension call and then use the standard find: mechanisms in our setup.cfg. Is there something setuptools-rust needs to tell setuptools so that it auto-discovers this package without this warning? Or, quite possibly, something we need to do on our end because we've done something dumb? 😄

Activity

  1. davidhewitt commented on Apr 26, 2023

    @davidhewitt
    davidhewitt
    on Apr 26, 2023
    Member

    Sorry for the extremely slow reply @reaperhulk. Did you find any answer to this? It's not a problem that I've observed, however if there's new checks in setuptools which can fail when using setuptools-rust it sounds like something which needs further investigation.

  2. alex commented on Apr 26, 2023

    @alex
    alex
    on Apr 26, 2023 via email
    Member

  3. davidhewitt commented on Apr 26, 2023

    @davidhewitt
    davidhewitt
    on Apr 26, 2023
    Member

    In which case I'll wait to see if any other users are noticing this and can provide a minimal repro. It doesn't look like this is blocking anyone at present, and my time is stretched very thin recently.

  4. reaperhulk commented on Apr 26, 2023

    @reaperhulk
    reaperhulk
    on Apr 26, 2023
    Author

    I spent some time investigating this a few months ago and it appeared at the time that there might not be a non-deprecated path available. I haven’t had a chance to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions