Skip to content

from_zero_restrictions could infer shock order from restriction counts #188

Closed

Description

@thomaspinder

From review of #183, UX only. A genuinely recursive pattern is rejected when shock_names is not pre-sorted most-restricted-first, although the correct order is recoverable from the restriction counts. The error message shows the expected set so users can recover; inferring the order would be friendlier. Files: src/impulso/identification.py.

Activity

  1. added a commit that references this issue on Jul 29, 2026
    d41b593
  2. added a commit that references this issue on Aug 1, 2026
    41e5234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions