Repository navigation
ci: tighten CI/CD pipeline - #10
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 18, 2026
thomaspinder
added a commit
that referenced
this pull request
May 18, 2026
…72) (#73) Previously, IRFResult/FEVDResult/HistoricalDecompositionResult collapsed the named (response, shock) axes into anonymous integer columns, and HD also lost its time axis via the (T*n, n) reshape. Callers had to reverse- engineer the flatten order, and per-row HD access silently misaligned. - src/impulso/results.py: add `_wide_frame` helper; rewrite IRF/FEVD/HD `.median()` and `.hdi()` to return wide DataFrames with `MultiIndex(['response','shock'])` on columns; integer horizon index for IRF/FEVD, DatetimeIndex for HD. `.to_dataframe()` stays as a `.median()` passthrough pending the dedicated follow-up (audit #9). - src/impulso/identified.py: attach `"time"` coord on the HD DataArray so the new HD accessor can build its DatetimeIndex. - src/impulso/plotting/_irf.py: replace `med.values[:, col_idx]` integer arithmetic with label-based `med[(resp, shock)]` lookups; pull shock names from the DataArray's `shock` coord. - tests/test_results.py: 9 new tests across IRF/FEVD/HD locking the new contract — MultiIndex column labels round-trip the underlying DataArray values, HD index is a DatetimeIndex matching `data.index[n_lags:]`, HDIResult.lower / .upper mirror shape and labels. Closes audit findings #1 and #10 (reports/audit-2026-05-18.md). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/release.py)uv run scripts/release.py patch|minor|major)Test plan
scripts/release.pyparses without errors🤖 Generated with Claude Code