Reset the IntradayVwap running sums - #9705
Merged
Martin-Molinero merged 1 commit intoAug 14, 2026
Merged
Conversation
Martin-Molinero
approved these changes
Aug 14, 2026
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IntradayVwap never overrode Reset(), so _sumOfVolume, _sumOfPriceTimesVolume and _lastDate survived it. Since IsReady is _sumOfVolume > 0, the indicator reported itself ready straight after a reset, and a replay inside the same session blended the previous volume into the average.
Closes #9703
Related Issue
#9703
Motivation and Context
TestHelper.AssertIndicatorIsInDefaultState asserts IsFalse(indicator.IsReady) and CommonIndicatorTests.ResetsProperly calls it for every indicator that has a test class. IntradayVwap had none, so the check that would have caught this has never run against it.
Requires Documentation Change
No.
How Has This Been Tested?
Added Tests/Indicators/IntradayVwapTests.cs with three tests: the default state after a reset, a replay reproducing the same values, and a same-session reset matching a fresh instance. All three fail with the override removed and pass with it.