Report NewHighsNewLows as not ready while no asset is tracked - #9706
Merged
Martin-Molinero merged 1 commit intoAug 14, 2026
Merged
Conversation
Martin-Molinero
approved these changes
Aug 14, 2026
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HasSufficientPreviousDataForComputation is an All over the tracked assets, and All holds over an empty set. IsReady is that predicate, so a NewHighsNewLows with nothing tracked reported itself ready with zero samples, and so did one whose last asset had been removed. Adding Any() in front settles both.
Closes #9704
Related Issue
#9704
Motivation and Context
Add and Remove are public, so a universe that empties reaches the state. ValidateAndComputeNextValue gates on the same predicate, and the HasMissingCurrentPeriodValue check three lines above it is an Any, false on an empty set, so nothing else stopped the call either. NewHighsNewLowsVolume inherits the same base.
Requires Documentation Change
No.
How Has This Been Tested?
Two tests on NewHighsNewLowsTestsBase, so they run for all three derived classes: a fresh indicator and one whose last asset was removed. Six fail without the guard. The NewHighsNewLows tests are 48 green with it.