Skip to content

fix(rankings): correct period labels and descriptions to match rollin… - #7722

Open
CupOfBread wants to merge 1 commit into
QuantumNous:mainfrom
CupOfBread:fix/rankings-period-labels
Open

CupOfBread wants to merge 1 commit into
QuantumNous:mainfrom
CupOfBread:fix/rankings-period-labels

Conversation

@CupOfBread

@CupOfBread CupOfBread commented Oct 10, 2026 •

Copy link
Copy Markdown

🔗 关联任务 / Related Issue

  • Closes #XXXX

🚀 变更类型 / Type of change

  • 🐛 Bug 修复 (Bug fix)

📝 变更描述 / Description

排行榜的周期标签「本周 / 本月 / 今年」与后端实际的滚动窗口(最近 7 / 30 / 365 天)不一致,误导用户对数据范围的理解。本次改动:

  • tab 标签改为「近 7 天 / 近 30 天 / 近一年」,使用专用 i18n key(不影响其他功能共用的 Week/Month/Year key)
  • 修正图表描述文案中遗留的「past few weeks / past month / past year」表述,与实际窗口一致
  • 新增 9 个 key 并同步 7 个 locale 文件

📸 运行证明 / Proof of Work

  • 7 个 locale JSON 均可正常解析
  • bun run i18n:sync 通过,所有 locale 无缺失 key
  • bun run build 通过
  • 手动验证:打开 /rankings 页面,确认 tab 显示「近 7 天 / 近 30 天 / 近一年」,图表描述与所选周期一致

✅ 提交前检查项 / Checklist

  • 人工确认
  • 非重复提交
  • 功能范围
  • 非透传
  • 范围聚焦
  • 本地验证
  • 安全合规

Summary by CodeRabbit

  • Improvements
    • Updated dashboard time-range labels and descriptions to clearly specify the last 7 days, last 30 days, and last year.
  • Localization
    • Added or updated translations for analytics time ranges and chart descriptions in French, Japanese, Russian, Vietnamese, Traditional Chinese, and Chinese.

…g time windows

The rankings tabs translated Week/Month/Year as 本周/本月/今年, but the
backend computes rolling windows of the last 7/30/365 days, so the labels
mislead users about the data range. Rename the tab labels to "Last 7
days", "Last 30 days", and "Last year" with dedicated i18n keys (the
existing Week/Month/Year keys stay for other features), and fix the
history chart descriptions that still said "past few weeks" / "past
month" / "past year".
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e2005ea2-1945-46c4-a138-3eb404706b8f

📥 Commits

Reviewing files that changed from the base of the PR and between 1d4328e and 3195063.


📒 Files selected for processing (10)
  • web/src/features/rankings/components/market-share-section.tsx
  • web/src/features/rankings/components/models-section.tsx
  • web/src/features/rankings/components/rankings-hero.tsx
  • web/src/i18n/locales/en.json
  • web/src/i18n/locales/fr.json
  • web/src/i18n/locales/ja.json
  • web/src/i18n/locales/ru.json
  • web/src/i18n/locales/vi.json
  • web/src/i18n/locales/zh-TW.json
  • web/src/i18n/locales/zh.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.



Walkthrough

Ranking period descriptions and labels now use explicit 7-day, 30-day, and yearly ranges. English, French, Japanese, Russian, Vietnamese, Traditional Chinese, and Chinese locale files add corresponding analytics labels and descriptions.

Changes

Ranking time ranges

Layer / File(s) Summary
Update ranking time-range wording
web/src/features/rankings/components/market-share-section.tsx, web/src/features/rankings/components/models-section.tsx, web/src/features/rankings/components/rankings-hero.tsx, web/src/i18n/locales/*.json
Weekly and monthly chart descriptions now specify the last 7 and 30 days. Period labels now read “Last 7 days,” “Last 30 days,” and “Last year.” Locale files add matching time-range labels and chart descriptions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 31950

The updated ranking labels and chart descriptions match the data windows, and no actionable merge risk remains.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the rankings period-label and description correction, which matches the primary changes in the pull request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the range labels bright,
Seven days, thirty days, then a year in sight.
Across each locale, the new words appear,
Chart descriptions make the time spans clear.
It hops away, its notes all neat,
And leaves the rankings fresh and sweet.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant