Skip to content

fix(router): make server fn discovery deterministic in Deno builds - #8550

Merged
Varixo merged 2 commits into
build/v2from
v2-deno-build-async
Apr 12, 2026
Merged

Varixo merged 2 commits into
build/v2from
v2-deno-build-async

Conversation

@Varixo

@Varixo Varixo commented Apr 12, 2026

Copy link
Copy Markdown
Member

Fix Deno build failure when routes using async tasks cause Rollup to exit early while loading virtual:qwik-router-server-fns.
The router Vite plugin now discovers server function modules deterministically instead of relying on background plugin loads, which avoids unresolved plugin promises during SSR builds.

@Varixo Varixo self-assigned this Apr 12, 2026
@Varixo
Varixo requested a review from a team as a code owner April 12, 2026 16:08
@Varixo Varixo added the V2 label Apr 12, 2026
@changeset-bot

changeset-bot Bot commented Apr 12, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a01a87

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Apr 12, 2026
@pkg-pr-new

pkg-pr-new Bot commented Apr 12, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8550

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8550

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8550

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8550

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8550

commit: 9a01a87

@github-actions

github-actions Bot commented Apr 12, 2026 •

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ❌ Failed (View Log) 9a01a87

@Varixo
Varixo force-pushed the v2-deno-build-async branch from a2b3309 to 50863a5 Compare April 12, 2026 16:53

@wmertens wmertens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nitpick

@Varixo
Varixo merged commit 826ae6d into build/v2 Apr 12, 2026
28 checks passed
@Varixo
Varixo deleted the v2-deno-build-async branch April 12, 2026 19:37
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[🐞] v2: intermittent build failure with Deno if useAsync$ (or alike) is used

2 participants