Skip to content

Revert #8752 - #8758

Merged
wmertens merged 1 commit into
build/v2from
revert-async-stopprop
Jun 21, 2026
Merged

wmertens merged 1 commit into
build/v2from
revert-async-stopprop

Conversation

@wmertens

Copy link
Copy Markdown
Member

ev.stopPropagation() and ev.preventDefault() are synchronous APIs and should not be used to steer async handling. Use shared state instead.

`ev.stopPropagation()` and `ev.preventDefault()` are synchronous APIs and should not be used to steer async handling. Use shared state instead.
@wmertens
wmertens requested a review from a team as a code owner June 21, 2026 10:58
Copilot AI review requested due to automatic review settings June 21, 2026 10:58
@wmertens
wmertens enabled auto-merge June 21, 2026 10:58
@changeset-bot

changeset-bot Bot commented Jun 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7b55702

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the previously added qwikloader behavior that attempted to honor ev.stopPropagation() / ev.preventDefault() from deferred (async/importing) event handlers, restoring purely synchronous propagation semantics in the loader.

Changes:

  • Remove the per-element deferred task grouping and cancelBubble re-check logic, and return to a single task queue for event dispatch.
  • Drop unit tests that asserted “deferred stopPropagation affects later deferred handlers” semantics.
  • Update qwikloader snapshot output and tighten the qwikloader brotli size budget accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/qwik/src/qwikloader.ts Reverts deferred propagation steering by removing grouped task flushing and simplifying event processing to a single task list.
packages/qwik/src/qwikloader.unit.ts Updates the inline snapshot for the generated/minified qwikloader script.
packages/qwik/src/qwikloader.behavior.unit.ts Removes behavior tests that depended on deferred stopPropagation() affecting later deferred handlers.
e2e/qwik-e2e/tests/qwikrouter/ssg-snapshot.e2e.ts Lowers the qwikloader brotli budget to reflect the smaller loader output after the revert.
.changeset/qwikloader-stoppropagation-deferred.md Removes the changeset associated with the reverted behavior change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}
});

test('applies parent preventdefault synchronously before async child bubbling completes', async () => {
@pkg-pr-new

pkg-pr-new Bot commented Jun 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8758

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8758

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8758

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8758

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8758

commit: 7b55702

@wmertens
wmertens merged commit 59cc1d8 into build/v2 Jun 21, 2026
50 checks passed
@wmertens
wmertens deleted the revert-async-stopprop branch June 21, 2026 11:06
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants