Repository navigation
Revert #8752 - #8758
Revert #8752#8758
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously added qwikloader behavior that attempted to honor ev.stopPropagation() / ev.preventDefault() from deferred (async/importing) event handlers, restoring purely synchronous propagation semantics in the loader.
Changes:
- Remove the per-element deferred task grouping and
cancelBubblere-check logic, and return to a single task queue for event dispatch. - Drop unit tests that asserted “deferred stopPropagation affects later deferred handlers” semantics.
- Update qwikloader snapshot output and tighten the qwikloader brotli size budget accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/qwik/src/qwikloader.ts | Reverts deferred propagation steering by removing grouped task flushing and simplifying event processing to a single task list. |
| packages/qwik/src/qwikloader.unit.ts | Updates the inline snapshot for the generated/minified qwikloader script. |
| packages/qwik/src/qwikloader.behavior.unit.ts | Removes behavior tests that depended on deferred stopPropagation() affecting later deferred handlers. |
| e2e/qwik-e2e/tests/qwikrouter/ssg-snapshot.e2e.ts | Lowers the qwikloader brotli budget to reflect the smaller loader output after the revert. |
| .changeset/qwikloader-stoppropagation-deferred.md | Removes the changeset associated with the reverted behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| }); | ||
|
|
||
| test('applies parent preventdefault synchronously before async child bubbling completes', async () => { |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
ev.stopPropagation()andev.preventDefault()are synchronous APIs and should not be used to steer async handling. Use shared state instead.