Repository navigation
test(qwik): fix stop-propagation in the events e2e fixture and pin deferred-handler loader behavior - #8791
Closed
maiieul wants to merge 2 commits into
Closed
test(qwik): fix stop-propagation in the events e2e fixture and pin deferred-handler loader behavior#8791maiieul wants to merge 2 commits into
maiieul wants to merge 2 commits into
Conversation
The #prevent-default-2 anchor called ev.stopPropagation() inside an async onClick$, which Qwik doesn't support — preventDefault/stopPropagation must be synchronous (via the preventdefault:/stoppropagation: attributes or sync$), so a call inside an async handler lands after the synchronous event-path walk. Use the stoppropagation:click attribute, like the #stop-propagation button, so the stop applies during the walk.
…n still runs later handlers
|
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
github-project-automation
Bot
moved this from Waiting For Review
to Done
in Qwik Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
The events e2e fixture used
ev.stopPropagation()inside an asynconClick$, which Qwik doesn't support (it lands after the synchronous event-path walk) — it now uses thestoppropagation:clickattribute. Also pins the stock loader behavior for deferred handlers with two regression tests. Found while working on #8745.