[xia-chao]

What is it?

• Bug

Description

withLocale('zh-CN', async () => { ... }) is supposed to keep getLocale() as zh-CN for the whole function, including after await.

That already works when AsyncLocalStorage is present. When it is not (browser build, some edge runtimes), the old code used try/finally. The finally runs the moment the function returns a Promise, so after await the locale is gone and getLocale() throws Reading locale outside of context.

This change waits until that Promise finishes (success or error), then puts the previous locale back. Sync withLocale is unchanged.

Related: this is the leftover hole after #8999, which taught Qwik how to find ALS on more runtimes. This PR is about the path that still has no ALS.

Checklist

• My code follows the developer guidelines of this project
• I performed a self-review of my own code
• I added a changeset with pnpm change
• I added new tests to cover the fix / functionality

[changeset-bot]

🦋 Changeset detected

Latest commit: 3a0b961

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@qwik.dev/core	Patch
@qwik.dev/devtools	Patch
eslint-plugin-qwik	Patch
@qwik.dev/react	Patch
@qwik.dev/router	Patch
@qwik.dev/utils	Patch
create-qwik	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Varixo]

hey! thanks for the PR, added small comment

[xia-chao]

@Varixo
yes! You are right!
Please review

[Varixo]

LGTM, thanks for the PR!

[pkg-pr-new]

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@9008

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@9008

@qwik.dev/utils

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/utils@9008

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@9008

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@9008

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@9008

@qwik.dev/devtools

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/devtools@9008

commit: 3a0b961